From owner-cvs-all Mon Feb 4 8:27:12 2002 Delivered-To: cvs-all@freebsd.org Received: from storm.FreeBSD.org.uk (storm.FreeBSD.org.uk [194.242.139.170]) by hub.freebsd.org (Postfix) with ESMTP id CE1ED37B41F; Mon, 4 Feb 2002 08:27:04 -0800 (PST) Received: (from uucp@localhost) by storm.FreeBSD.org.uk (8.11.6/8.11.6) with UUCP id g14GR4C51643; Mon, 4 Feb 2002 16:27:04 GMT (envelope-from mark@grondar.za) Received: from greenpeace.grondar.org (greenpeace [192.168.42.2]) by gratis.grondar.org (Postfix) with ESMTP id 2297F37D; Mon, 4 Feb 2002 16:20:26 +0000 (GMT) Received: from grondar.za (localhost [127.0.0.1]) by greenpeace.grondar.org (8.11.6/8.11.6) with ESMTP id g14GG7E56111; Mon, 4 Feb 2002 16:16:07 GMT (envelope-from mark@grondar.za) Message-Id: <200202041616.g14GG7E56111@greenpeace.grondar.org> To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys socket.h types.h References: <20020205002930.K22843-100000@gamplex.bde.org> In-Reply-To: <20020205002930.K22843-100000@gamplex.bde.org> ; from Bruce Evans "Tue, 05 Feb 2002 00:44:22 +1100." Date: Mon, 04 Feb 2002 16:16:02 +0000 From: Mark Murray Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > > So how does one write a (decent) macro to return a correct value > > for min(1u, -1)? > > One doesn't. One can write fairly indecent ones using Gnu C, but > FreeBSD currently uses min functions instead of the MIN macro in the > kernel. > > > howmany() is used so much in the kernel, and is defined in multiple > > places, so methinks it needs to be a function (inline?). It kicks > > out zillions of wanings when you try to lint it. > > The warnings are probably correct. They probably indicate that callers > are passing mismatched arg types. Your thoughts on turning howmany() into a function? > Perhaps more seriously, the change to the type of NBBY exposes an old > bug in ffs and causes kernel panics. See another thread. Please > back it out too, and consider doing the same for all the other type > changes. If that is a bug, then surely that is what needs fixing? M -- o Mark Murray \_ FreeBSD Services Limited O.\_ Warning: this .sig is umop ap!sdn To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message