From owner-freebsd-net@FreeBSD.ORG  Sun Dec 14 14:54:21 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 220E81C7
 for <freebsd-net@freebsd.org>; Sun, 14 Dec 2014 14:54:21 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D81112DD
 for <freebsd-net@freebsd.org>; Sun, 14 Dec 2014 14:54:20 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 sBEEsK9M024018
 for <freebsd-net@freebsd.org>; Sun, 14 Dec 2014 14:54:20 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id sBEEsKOV024017;
 Sun, 14 Dec 2014 14:54:20 GMT (envelope-from root)
Date: Sun, 14 Dec 2014 14:54:20 +0000
To: freebsd-net@freebsd.org
From: "rodrigc (Craig Rodrigues)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Request, 100 lines] D1315: VIMAGE PF fixes #4
Message-ID: <differential-rev-PHID-DREV-k72fyxmql5uyge3yepnq-req@FreeBSD.org>
X-Priority: 3
Thread-Topic: D1315: VIMAGE PF fixes #4
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-d4twv4w2hsoq7prc6boa>
X-Phabricator-To: <PHID-USER-mqlw6f5jjiqhbs4co7yd>
X-Phabricator-To: <PHID-USER-d7hlhjvonwbh6sezyfcn>
X-Phabricator-To: <PHID-USER-jfdfp3ujmysz623mloir>
X-Phabricator-To: <PHID-USER-q3rwaaecfkbtb4lxr2gr>
X-Phabricator-To: <PHID-USER-gwqhkhyjx2ztt7b5iohf>
X-Phabricator-To: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-Cc: <PHID-MLST-crbi54kg7ihel5ezzzmu>
X-Phabricator-Cc: <PHID-MLST-5lcr2rqsbmuavxbsw4mm>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
Thread-Index: ZGI1YWY1MTBmYjU4M2RhM2FhZDQyNzA4YWQ1
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-other>, <differential-reviewers>,
 <differential-cc>, <differential-review-request>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Dec 2014 14:54:21 -0000

rodrigc created this revision.
rodrigc added reviewers: bz, glebius, trociny, network.
rodrigc added subscribers: freebsd-net, freebsd-pf, freebsd-virtualization.

REVISION SUMMARY
  Instead of creating a purge thread for every vnet, create
  a single purge thread and clean up all vnets from this thread.

TEST PLAN
  (1)  Boot a kernel with VIMAGE enabled
  (2)  Create a vnet jail
           jail -c persist name=testjail001 vnet path=/ host.hostname=testjail001 allow.raw_sockets allow.socket_af
  
  (3)  Start pf inside the jail
          service start pf
  
  (4)  Delete the vnet jail
          jail -r testjail001
  
  Without this patch, the kernel would panic in step (4).  With the patch,
  the kernel does not panic

REVISION DETAIL
  https://reviews.freebsd.org/D1315

AFFECTED FILES
  sys/net/pfvar.h
  sys/netpfil/pf/pf.c
  sys/netpfil/pf/pf_ioctl.c

To: rodrigc, bz, glebius, trociny, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson
Cc: freebsd-virtualization, freebsd-pf, freebsd-net