From owner-dev-commits-src-all@freebsd.org Sun Jun 6 17:37:32 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5460863A3E6; Sun, 6 Jun 2021 17:37:32 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [IPv6:2001:19f0:6400:80a1:5054:ff:fe7a:a27d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FykGh1YDkz3PKp; Sun, 6 Jun 2021 17:37:32 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.16.1/8.16.1) with ESMTP id 156HbKAq050466; Sun, 6 Jun 2021 17:37:20 GMT (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.16.1/8.16.1/Submit) id 156HbKCO050465; Sun, 6 Jun 2021 17:37:20 GMT (envelope-from dchagin) Date: Sun, 6 Jun 2021 17:37:20 +0000 From: Dmitry Chagin To: Lutz Donnerhacke Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0f8dab45404f - main - linux(4): Fix timeout parameter of rt_sigtimedwait syscall, which is timespec not a timeval. Message-ID: References: <202106061440.156EeLEK068536@gitrepo.freebsd.org> <20210606163708.GA10633@belenus.iks-jena.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210606163708.GA10633@belenus.iks-jena.de> X-Rspamd-Queue-Id: 4FykGh1YDkz3PKp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jun 2021 17:37:32 -0000 On Sun, Jun 06, 2021 at 06:37:08PM +0200, Lutz Donnerhacke wrote: > On Sun, Jun 06, 2021 at 02:40:21PM +0000, Dmitry Chagin wrote: > > The branch main has been updated by dchagin: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0f8dab45404f347752470579feccc6d2739b9570 > > > > commit 0f8dab45404f347752470579feccc6d2739b9570 > > Author: Dmitry Chagin > > AuthorDate: 2021-06-07 02:35:35 +0000 > > Commit: Dmitry Chagin > > CommitDate: 2021-06-07 02:35:35 +0000 > > > > linux(4): Fix timeout parameter of rt_sigtimedwait syscall, which is > > timespec not a timeval. > > > > MFC after: 2 weeks > > May I ask, why NONE of those commits are discussed beforehand in Phabricator? > freebsd/main is not intended to be used as a local development train by > anybody who wants to play with a specific submodule. > in the main, these are trivial changes, there too few reviewrs in the Linuxulator area to spend their time. feel free to review, there are many requests. > I don't want to see any of those "try and fix" commits to be MFCed into any > stable without serious squashing and fixup runs, in order to minimize the > impact on the stable trains. If there is a known bug in the commit, the > MFCed commit must contain all the known necessary fixes to avoid any > breakage of the stable train. > > So please do not mess up the freebsd/main any further. Thank you. please, re-read the committer's guide carefully, especially about committers relations and pre-commit review.