From owner-freebsd-toolchain@FreeBSD.ORG Wed Sep 12 14:48:24 2012 Return-Path: Delivered-To: toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05ABA106566B for ; Wed, 12 Sep 2012 14:48:24 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 508928FC19 for ; Wed, 12 Sep 2012 14:48:23 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.5/8.14.5) with ESMTP id q8CEmL9Z085604; Wed, 12 Sep 2012 09:48:21 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.5/8.14.5/Submit) id q8CEmLJr085603; Wed, 12 Sep 2012 09:48:21 -0500 (CDT) (envelope-from brooks) Date: Wed, 12 Sep 2012 09:48:21 -0500 From: Brooks Davis To: Warner Losh Message-ID: <20120912144821.GB77434@lor.one-eyed-alien.net> References: <20120910215656.GD64920@lor.one-eyed-alien.net> <5242C5EF-B357-4EBA-8302-2C836ECC01BB@bsdimp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l76fUT7nc3MelDdI" Content-Disposition: inline In-Reply-To: <5242C5EF-B357-4EBA-8302-2C836ECC01BB@bsdimp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: toolchain@freebsd.org Subject: Re: improving bootstrapping of WITH_CLANG_IS_CC X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2012 14:48:24 -0000 --l76fUT7nc3MelDdI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 12, 2012 at 03:43:39AM -0500, Warner Losh wrote: >=20 > On Sep 10, 2012, at 4:56 PM, Brooks Davis wrote: > > .if ${COMPILER_TYPE} !=3D "clang" > >=20 > > I'd like to commit this in the next few days unless there are objections > > requiring a major redesign. >=20 > Due to other $LIFE happening, I just scanned the patch, but I really like= it. >=20 > I'd also propose a COMPILER_VERSION variable be reserved so that can be s= et so that variations in compiler versions can be comprehended in the tree = to allow easier external toolchain support as well. I have no impl for thi= s yet, but just thought I'd put a bug in people's ear. I think we'll likely want something like or a COMPILER_FEATURES variable eventually. For the moment I'm avoiding implementing it to avoid the problems associated with generalizing from no examples. One of the ideas we talked about at the devsummit was allowing external toolchains to provide a makefile to drive things like CFLAGS for WARNS. I think this would be a very good approach since it could allow a much broader range of compilers without necessarily requiring FreeBSD developers to know about all the possible variants. -- Brooks --l76fUT7nc3MelDdI Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFQUKC0XY6L6fI4GtQRAjO6AJ9adtn82F505Y9X/eErpc3wH5SLWgCg4p1C LlQHV5a2MpuaW0GjD7boBlw= =KQHx -----END PGP SIGNATURE----- --l76fUT7nc3MelDdI--