From nobody Fri Apr 17 19:37:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fy4sk61gWz6Wwd6 for ; Fri, 17 Apr 2026 19:37:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fy4sj6yVxz454h for ; Fri, 17 Apr 2026 19:37:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776454666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VawBEbvb9+XfENIHJFn6bgcHhsjfUSz8w89BpvJqCyE=; b=S6marp99va3obaJ69l57qAabtzqKzqY8tTMqjg3ip7scYcrF8ZC2gS1LFWP6r285ArXdZ/ dEe2TiJqQ2K4xmgxO1sfYQcOjd3BOaVLcL5Loh7o9VeggwY3ia20rOWfUVn9zmbIjnxGSW Cdf7Vwg+BCaLKMeVCD7aX08andWAgRZpv6BfIxqce/ajYQ1MMGNfLTjmjwa2FcPdWsJLYY qRUSjv7sd3FA0E9ANSA+ihhzTAjuH0hR4ynwvNxQeLfn0t0dzldplIo0jO3tbnV/ToFX8a 5353NJJum/6xGZFi7tBN2pG/XsJauDICKmvEJ3wwDM+5yeSMBYsQuTzpE3WuiQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776454666; a=rsa-sha256; cv=none; b=t0IQ3PJe7ai62xMenaV+IRfpAGhn+/pmJKnCa1i5wKHnI63kxyNPaqa+Wl8l883ddR4HJI n5jXS9CcgES2uXMvmUyydRfXpi+Ot9EHxUHBINXh/KFTua+IKfmjrqfYWnGVgbJT3vYuIb VnXtR6K0HNCs+PQsn0KMYJ511QGx7fcR9mCe2d7IH+0fKWsypu0rg3oJ5jAZmFbxcAtOgK ldpnkmBdw3ZCqVe8VRhZeMRGDzvwRllPlfMmf2t2Wq3OXrkqd+voQPZ6Rn0YEUbJAPtNuv csPBoblrP2Mx2LW36OlR1bKFu0w4V3Wqb4BQ+knhxOMJ1sFEuF93vFF/hE6o3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776454666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VawBEbvb9+XfENIHJFn6bgcHhsjfUSz8w89BpvJqCyE=; b=Yyfys/9b+j9etwyyQMF2wie4HR8gXIX5lskXOLOjTK/DGzX9r0MuxoobtvhLnckeQ0o8zx HfMXjK5BHuLgFnuFSJDjI98/IDrI0EfDA6md1JqXYCMnTRzNpwBu1xWAKb4yMoh515g0Q1 3PF0Nx+W8KoiM/C63fLPW/mxugB7Jstpcs2ydyV8t02owhQNaFEtDx+dYPY2MxCl7eS7Eb uEsG4a9ul+zI9GfJ7RefFjTKtaj713/X57/BISyDLQeEEjaZerPyDV1bxWQJW2P5VGfqVN wJNGJ/Pu4r8Hdfo5M0Ss2jNp9aYKhP+TG6JLn/rbAvJ196JlBNSYGSkVxEYjmw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fy4sj6WcRz16Tf for ; Fri, 17 Apr 2026 19:37:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1bb57 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 17 Apr 2026 19:37:40 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Roger Pau =?utf-8?Q?Monn=C3=A9?= Subject: git: 45c8ddc874bb - main - uart/pci: recover ADL AMT device after FIFO size probing List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: royger X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 45c8ddc874bb9149ed20cb46b6ef8bdd0567714c Auto-Submitted: auto-generated Date: Fri, 17 Apr 2026 19:37:40 +0000 Message-Id: <69e28c04.1bb57.42d4783d@gitrepo.freebsd.org> The branch main has been updated by royger: URL: https://cgit.FreeBSD.org/src/commit/?id=45c8ddc874bb9149ed20cb46b6ef8bdd0567714c commit 45c8ddc874bb9149ed20cb46b6ef8bdd0567714c Author: Roger Pau Monné AuthorDate: 2026-03-27 09:55:02 +0000 Commit: Roger Pau Monné CommitDate: 2026-04-17 19:37:26 +0000 uart/pci: recover ADL AMT device after FIFO size probing When the Alder Lake Serial-over-LAN device is put into loopback mode and repeated writes are performed to the data register it results in the device ending up in a non-functional state afterwards. Recovering the device to a working state requires re-writing the LCR register with it's current value (no effective change). This should be harmless on all other devices. Sponsored by: Citrix Systems R&D Differential revision: https://reviews.freebsd.org/D56107 Reviewed by: imp --- sys/dev/uart/uart_dev_ns8250.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/dev/uart/uart_dev_ns8250.c b/sys/dev/uart/uart_dev_ns8250.c index b0c7cd4b44e1..c13eabe9055e 100644 --- a/sys/dev/uart/uart_dev_ns8250.c +++ b/sys/dev/uart/uart_dev_ns8250.c @@ -999,6 +999,15 @@ ns8250_bus_probe(struct uart_softc *sc) uart_setreg(bas, REG_IER, ier); uart_setreg(bas, REG_MCR, mcr); uart_setreg(bas, REG_FCR, 0); + /* + * The Alder Lake AMT SOL Redirection device will never + * set LSR_OE (when in loopback mode at least) and + * instead block further input by not setting LSR_TEMT. + * Recovering the device afterwards into a working + * state requires re-writing the LCR register. This + * should be harmless on all other devices. + */ + uart_setreg(bas, REG_LCR, uart_getreg(bas, REG_LCR)); uart_barrier(bas); count = 0; goto describe;