Date: Sat, 19 Oct 2002 16:30:03 -0700 (PDT) From: Kris Kennaway <kris@obsecurity.org> To: freebsd-ports@FreeBSD.org Subject: Re: ports/44287: Fix build of mail/xmail Message-ID: <200210192330.g9JNU3eW082364@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/44287; it has been noted by GNATS. From: Kris Kennaway <kris@obsecurity.org> To: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: ports/44287: Fix build of mail/xmail Date: Sat, 19 Oct 2002 16:24:46 -0700 On Sat, Oct 19, 2002 at 03:32:25PM -0700, Steven G. Kargl wrote: > extern char noshare *sys_errlist[]; > #else > extern int errno; > -extern int sys_nerr; > -extern char *sys_errlist[]; > #endif You should avoid defining errno as well - it doesn't currently cause an error, but it's wrong. Instead of patching these out, you should conditionally compile them in the !defined(__FreeBSD__) case. This will make the patch more acceptable to be taken back by the upstream author. Kris To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200210192330.g9JNU3eW082364>