Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Oct 2022 16:40:43 +0200
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Dmitry Marakasov <amdmi3@amdmi3.ru>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: c698371b0910 - main - devel/sdl20: fix armv7-related check in SDL_atomic.h
Message-ID:  <Yz2XaxW5GKHVy%2BUO@KGPE-D16>
In-Reply-To: <Yz2A1Sid9PCU%2B1%2BO@hades.panopticon>
References:  <202209291355.28TDt7Ln090671@gitrepo.freebsd.org> <Yz2A1Sid9PCU%2B1%2BO@hades.panopticon>

next in thread | previous in thread | raw e-mail | index | archive | help

--ueTt2oNYe8nMXAn+
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

OK, thanks for feedback, but I don't really remember such an email.

On 22-10-05 16:04:21, Dmitry Marakasov wrote:
> * Piotr Kubaj (pkubaj@FreeBSD.org) wrote:
>=20
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dc698371b0910e792db5690=
126bde955456fdccd2
> >=20
> > commit c698371b0910e792db5690126bde955456fdccd2
> > Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > AuthorDate: 2022-09-29 13:51:25 +0000
> > Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > CommitDate: 2022-09-29 13:54:40 +0000
> >=20
> >     devel/sdl20: fix armv7-related check in SDL_atomic.h
> >    =20
> >     Fixes build errors like:
> >      In file included from /usr/ports/games/openrct2/work/OpenRCT2-0.4.=
1/src/openrct2-ui/CursorRepository.h:12: In file included from /usr/local/i=
nclude/SDL2/SDL.h:35: /usr/local/include/SDL2/SDL_atomic.h:243:28: error: '=
__ARM_ARCH__' is not defined, evaluates to 0 [-Werror,-Wundef] #elif (defin=
ed(__arm__) && __ARM_ARCH__ >=3D 7) || defined(__aarch64__)
> > ---
> >  devel/sdl20/Makefile | 4 ++++
> >  devel/sdl20/distinfo | 4 +++-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/devel/sdl20/Makefile b/devel/sdl20/Makefile
> > index d84a9679030b..6e8c2c390ba6 100644
> > --- a/devel/sdl20/Makefile
> > +++ b/devel/sdl20/Makefile
> > @@ -1,9 +1,13 @@
> >  PORTNAME=3D	sdl2
> >  DISTVERSION=3D	2.24.0
> > +PORTREVISION=3D	1
> >  CATEGORIES=3D	devel
> >  MASTER_SITES=3D	https://www.libsdl.org/release/
> >  DISTNAME=3D	SDL2-${PORTVERSION}
> > =20
> > +PATCH_SITES=3D	https://github.com/libsdl-org/SDL/commit/
> > +PATCHFILES=3D	a204ef50bbf20b77083c0a14124e673efc3a53c6.patch:-p1
>=20
> I think I've already asked, but I'm not sure it was you. Please do not
> ever introduce this kind of unmaintainable ugliness to my ports.
> All patches should be put under files/.
>=20
> >  MAINTAINER=3D	amdmi3@FreeBSD.org
> >  COMMENT=3D	Cross-platform multimedia development API
> >  WWW=3D		https://www.libsdl.org/
> > diff --git a/devel/sdl20/distinfo b/devel/sdl20/distinfo
> > index 3f836d60852a..c78d82f18d9c 100644
> > --- a/devel/sdl20/distinfo
> > +++ b/devel/sdl20/distinfo
> > @@ -1,3 +1,5 @@
> > -TIMESTAMP =3D 1661880729
> > +TIMESTAMP =3D 1664457277
> >  SHA256 (SDL2-2.24.0.tar.gz) =3D 91e4c34b1768f92d399b078e171448c6af18ca=
fda743987ed2064a28954d6d97
> >  SIZE (SDL2-2.24.0.tar.gz) =3D 7520541
> > +SHA256 (a204ef50bbf20b77083c0a14124e673efc3a53c6.patch) =3D 2cc9607f42=
acc8b00ac058cbc5fcba3d7037db21db679533afd483824dd5b658
> > +SIZE (a204ef50bbf20b77083c0a14124e673efc3a53c6.patch) =3D 1168
> >=20
>=20
> --=20
> Dmitry Marakasov   .
> amdmi3@amdmi3.ru  ..:  https://github.com/AMDmi3  https://amdmi3.ru/
>=20

--ueTt2oNYe8nMXAn+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmM9l2sACgkQelmbhSCD
nJ2fGxAAp/CrL+k6i3ZP5xfqUM1zuJsnjKHdW7L726XGAPfOAj2WKwna3hlb8dHK
GeLNW8VzxNvkHRKXW0CGhsj4AxEDdyLhn1JL5FfuZ90Zwj13dHbLGdHJOynGItXz
TH8XkIA6+K8O+gYoe34E8Xuf1AP/4FkumUm7zpdsM2tysaNIjqDofs/nLzXe9jOp
/LGLKSDP8kd/zbRJiwJoYraSuKE2xpMoiBUC86MWRZ1+m7cDzlt5hBFwvCEhZ8LQ
Vn+ftZA/Iqf1aAH6UwdpYa55mtag2u3ZbsGMSZ9gjV4X87VqSXt/r/nyJ5+u9hGo
VIaWKPhOBqrOjTQsKFQ5jToSI018vr7ZCOb3O224YVzy7W4Vr5dOLD3Xg92ilzUH
PDRlALVYYmXh94pzNu2nEwg7/9Qjwv9m55ZjQ738plwR6nxQLBkBC3PJpxu6RX3u
ezCX/fMfOwPEQXzFSlLZe1lJ1VN5rQ0+Vf9cYvcLmYOH99oGvkBDoaY7c24/pcx+
Er3Ii2NBqUOP899XxHhpz8CbadLQlLcTjG+zOE0ZjMGXuKgYYEFIKqkYK3abxRgx
bgK5yowZ7t2sk24OAOrG0og6QPvvQqnXOslvg3TX8jQ4Msui6rCEae3/xXwxfOQ1
/yeWjQV84rkwgeTse5J/h8elcyHmD/nBQGVAB2fYS64oVFbOY18=
=Og0i
-----END PGP SIGNATURE-----

--ueTt2oNYe8nMXAn+--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yz2XaxW5GKHVy%2BUO>