From nobody Mon Mar 9 16:38:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fV2l370Psz6TV27 for ; Mon, 09 Mar 2026 16:38:39 +0000 (UTC) (envelope-from bounce.q2lildups38nra0=b4ueu3n9w9y2=kxjzjbl84idvn7@return.smtpservice.net) Received: from e3i531.smtp2go.com (e3i531.smtp2go.com [158.120.86.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fV2l34CxCz3Kcy for ; Mon, 09 Mar 2026 16:38:39 +0000 (UTC) (envelope-from bounce.q2lildups38nra0=b4ueu3n9w9y2=kxjzjbl84idvn7@return.smtpservice.net) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smtpservice.net; i=@smtpservice.net; q=dns/txt; s=a1-4; t=1773074314; h=feedback-id : x-smtpcorp-track : date : message-id : to : subject : from : reply-to : sender : list-unsubscribe : list-unsubscribe-post; bh=IWgZyHABWKYN1DiRQDarLERHtJuJ8IqGYhmYjp+KdRU=; b=ocBvXINYdyhanaZPejyzu/cLq/lE1zTEpa7NaW34egH+MjFKCsBCeQmeDuDRr4DYbSUwj KMaoYn+mNjQ1pwg7lcS/V7Bh2HinQt58iI0Yn37mE0ip5nt0FBH4zEoQ194kNB05mj+nEhg 18mPGPeNXJA5IqwPLe8MKhPTog5+RnX4qRRPgGhgbyCwfqgqx+zojN1Xw2jhS0JU0tNP0iU T6OvPThl18lwkWFTSGb+bMuON1Raka/ieIkLAfCzkPdX+7e4czp1R4Q5TGNp7XNEZsvRRI/ WPWLl9C8/jw/FrYL7vry/7BsCTsRpIT+BHi/47DP3B1c+wIHfYTxrMjcxxIQ== Received: from [10.99.243.232] (helo=morbo.fubar.geek.nz) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.99.1-S2G) (envelope-from ) id 1vzdcq-4o5NDgroRPr-kLOy; Mon, 09 Mar 2026 16:38:36 +0000 Received: from smtpclient.apple (unknown [IPv6:2a02:8012:a6a8:0:8835:d8b5:711e:47ee]) by morbo.fubar.geek.nz (Postfix) with ESMTPSA id 6282F4773E; Mon, 09 Mar 2026 16:38:35 +0000 (UTC) From: Andrew Turner Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_35E9251D-96F6-4D90-905F-5A2D21E10EAE" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: git: c499ad6f997c - main - virtio: Use bus_dma for ring and indirect buffer allocations Date: Mon, 9 Mar 2026 16:38:24 +0000 In-Reply-To: <87ecludxuh.wl-herbert@gojira.at> Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Sarah Walker To: "Herbert J. Skuhra" References: <69a71c75.40215.43f39fc6@gitrepo.freebsd.org> <87ecludxuh.wl-herbert@gojira.at> X-Mailer: Apple Mail (2.3826.700.81) X-Report-Abuse: Please forward a copy of this message, including all headers, to Feedback-ID: 790814m:790814amQcrys:790814sxRKYBK6LQ X-smtpcorp-track: 252ju4s4zCjx.FVfOWIPBxZru.fQ_i2w6xc9M X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:23352, ipnet:158.120.84.0/22, country:US] X-Rspamd-Queue-Id: 4fV2l34CxCz3Kcy X-Spamd-Bar: ---- --Apple-Mail=_35E9251D-96F6-4D90-905F-5A2D21E10EAE Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 8 Mar 2026, at 17:39, Herbert J. Skuhra wrote: >=20 > On Tue, 03 Mar 2026 18:37:57 +0100, Andrew Turner wrote: >>=20 >> The branch main has been updated by andrew: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc499ad6f997c8c5f61c88925e6d1e826= d0c0f6c4 >>=20 >> commit c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4 >> Author: Sarah Walker >> AuthorDate: 2026-03-03 16:08:11 +0000 >> Commit: Andrew Turner >> CommitDate: 2026-03-03 16:29:15 +0000 >>=20 >> virtio: Use bus_dma for ring and indirect buffer allocations >>=20 >> While the majority of virtio platforms will be fully coherent, = some may >> require cache maintenance or other specific device memory handling = (eg for >> secure partitioning). Using bus_dma allows for these usecases. >>=20 >> The virtio buffers are marked as coherent; this should ensure that = sync >> calls are no-ops in the common cases. >>=20 >> Reviewed by: andrew >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D54959 >> --- >> sys/dev/virtio/virtio_ring.h | 27 ++++-- >> sys/dev/virtio/virtqueue.c | 216 = +++++++++++++++++++++++++++++++++++++------ >> 2 files changed, 209 insertions(+), 34 deletions(-) >=20 > After this change I see a lot of "kernel: vtnet0: watchdog timeout on > queue xx" errors on amd64 (arm64 seems to be OK). >=20 > Reverting this commit resolves the issue. Can you try the change in https://reviews.freebsd.org/D55766? It re-adds = memory barriers for amd64. Andrew --Apple-Mail=_35E9251D-96F6-4D90-905F-5A2D21E10EAE Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On 8 Mar = 2026, at 17:39, Herbert J. Skuhra <herbert@gojira.at> = wrote:

On Tue, 03 Mar 2026 = 18:37:57 +0100, Andrew Turner wrote:

The branch main has been updated by = andrew:

URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc499ad6f997c8c5f61c88925e6d1e826= d0c0f6c4

commit = c499ad6f997c8c5f61c88925e6d1e826d0c0f6c4
Author: =     Sarah Walker = <sarah.walker2@arm.com>
AuthorDate: 2026-03-03 16:08:11 = +0000
Commit:     Andrew Turner = <andrew@FreeBSD.org>
CommitDate: 2026-03-03 16:29:15 = +0000

   virtio: Use bus_dma for ring and indirect = buffer allocations

   While the majority of virtio = platforms will be fully coherent, some may
   require = cache maintenance or other specific device memory handling (eg = for
   secure partitioning). Using bus_dma allows for = these usecases.

   The virtio buffers are marked = as coherent; this should ensure that sync
   calls are = no-ops in the common cases.

   Reviewed by: =    andrew
   Sponsored by: =   Arm Ltd
   Differential Revision: =  https://reviews.freebsd.org/D54959
---
sys/dev/virtio/virtio_r= ing.h |  27 ++++--
sys/dev/virtio/virtqueue.c   | 216 = +++++++++++++++++++++++++++++++++++++------
2 files changed, 209 = insertions(+), 34 deletions(-)

After = this change I see a lot of "kernel: vtnet0: watchdog timeout = on
queue xx" errors on = amd64 (arm64 seems to be OK).

Reverting this commit resolves the = issue.

Can you try the change = in https://reviews.freebsd.org/D= 55766? It re-adds memory barriers for = amd64.

Andrew

= --Apple-Mail=_35E9251D-96F6-4D90-905F-5A2D21E10EAE--