From owner-freebsd-bugs@freebsd.org Tue Oct 30 23:27:41 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72E961037C26 for ; Tue, 30 Oct 2018 23:27:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1042380025 for ; Tue, 30 Oct 2018 23:27:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C89AE1037C21; Tue, 30 Oct 2018 23:27:40 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6BDE1037C20 for ; Tue, 30 Oct 2018 23:27:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 480008001F for ; Tue, 30 Oct 2018 23:27:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8844D1A015 for ; Tue, 30 Oct 2018 23:27:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w9UNRdta020547 for ; Tue, 30 Oct 2018 23:27:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w9UNRdYn020546 for bugs@FreeBSD.org; Tue, 30 Oct 2018 23:27:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 232835] [gmirror] gmirror fails to recover from degraded mirror sets in some circumstances (2/n) Date: Tue, 30 Oct 2018 23:27:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc dependson blocked Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Oct 2018 23:27:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232835 Bug ID: 232835 Summary: [gmirror] gmirror fails to recover from degraded mirror sets in some circumstances (2/n) Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: cem@freebsd.org CC: geom@FreeBSD.org, markj@FreeBSD.org Depends on: 232671 Blocks: 232683, 232684 This is related to bug 232671 , but not identical. Here is the example scenario: 1. I start with a GMIRROR with three ACTIVE disks (sc_ndisks =3D md_all =3D 3) 2. I essentially disconnect one of the disks 3. The remaining mirrors lower md_all to 2 and the syncid / generation gets bumped 4. I reboot, and the removed disk reappears 5. Geom tastes the stale removed disk first, and populates sc_ndisks from its md_all (3) 6. The two valid mirrors are tasted afterwards and the gmirror rejects both as having invalid metadata (md_all=3D2), despite their having a higher generation / sync id The problem is basically that gmirror doesn't "upgrade" its metadata to the newest valid mirrorset it finds -- it just sticks with whatever it found first. I think the solution is being a bit clever about detecting the latest mirror generation while a gmirror is still in the STARTING state; and also perhaps a little more clever about when we transition from STARTING to RUNNING (at which point a newer generation mirror showing up means we have corruption). Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232671 [Bug 232671] [gmirror] gmirror fails to recover from degraded mirror sets in some circumstances https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232683 [Bug 232683] [gmirror] gmirror could provide much better administrative introspection into decision-making processes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232684 [Bug 232684] [gmirror] gmirror overly aggressive provider destruction --=20 You are receiving this mail because: You are the assignee for the bug.=