From owner-dev-commits-src-all@freebsd.org Fri Jan 8 14:54:53 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B73324CC891 for ; Fri, 8 Jan 2021 14:54:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DC5jn4dLkz4V6W for ; Fri, 8 Jan 2021 14:54:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x736.google.com with SMTP id v126so8565625qkd.11 for ; Fri, 08 Jan 2021 06:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jnoULEh2eyovthNxBNKvFzzndbt0XZc8T9/xuF6G+Ps=; b=aBYUfjUkvh9kFc1JWRA8KM8abUxRRZqMeQDaoxkivawATdcWzV2xA7QbolAkc9n/qV Ovlyb45ShkRQ7cHE9tbx8Elao1KWy/d6fg3kIjygpSyBKKMUPvcbEq2qP3ExYokZxNIa Bjg5DqlUo7JO5Hpch5o2YlJEB4euxq3Mksj0rCFvm3XwTpjYD0dP9hLKDwj47ldbqDfe iAgIZ9weQJBVOFbgiuR+aM5s/ymVX3P2vnorPUf29nHUzlwn3U7Ax2Fz5uJzxT0x3tUf 818kkWzZykQjAqc0UVRXcU9lfalRVrkShyvAPiH03QqdNPKvgho0byAqGtREf3hSOZnX p85g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jnoULEh2eyovthNxBNKvFzzndbt0XZc8T9/xuF6G+Ps=; b=h7wYRnrE4AtmJSkfPzaqaRz9i3sqzzL5+cLh+qMUyKpgj1AiUTuQ7/bzHI/i33AP82 0eTs6+6hk7wwh9rFe9bE/GfoXBliefb6YSDlJZmrhaGTa68QrZiYltXSNh9AsORshF9d NUY8FUo53NtbJWbxbVJM8XOMerNlsQvgQnefsVSxzh+C9LbB5xKI74LZID3C/j0ux3VY H44pVJcyOvEjgZ4nOhTv8cqa1wz/UOBVuDNGdWuffW2aMxuVpUxO2HpXsAuZ2yu85gS3 Ho3vvdlUnAFPXDjJYedKA2B2AS9YcfjtdmyqPf0C/P6adSz2/XAnMwrh00jKcbYsevnv sL2Q== X-Gm-Message-State: AOAM531D6d+W+dKQxOzQ1mUQBwoRCCPRplp6x5ktBJhY72TR93+peNUq V3Tu5Mtxk9DSkgo3EJp51mFccY1Pnljd4/eaVtvs2g== X-Google-Smtp-Source: ABdhPJy+ZjaLdBXay8POy+O+QXDIqi9gqfrL+asePSju07Fox1o6GBCPKxPygT4+O22Y151pQ4ReXZP8+bI4unLNfco= X-Received: by 2002:a37:a614:: with SMTP id p20mr4104006qke.359.1610117692725; Fri, 08 Jan 2021 06:54:52 -0800 (PST) MIME-Version: 1.0 References: <202101070924.1079OE4g081849@gitrepo.freebsd.org> <52e99dc8-cd75-a2ab-7670-b81d8aaa8134@FreeBSD.org> In-Reply-To: <52e99dc8-cd75-a2ab-7670-b81d8aaa8134@FreeBSD.org> From: Warner Losh Date: Fri, 8 Jan 2021 07:54:41 -0700 Message-ID: Subject: Re: git: 74bd20769706 - main - Reference newfs_msdos(8) from the newfs(8) manual To: Mateusz Piotrowski <0mp@freebsd.org> Cc: Konstantin Belousov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4DC5jn4dLkz4V6W X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 14:54:53 -0000 On Fri, Jan 8, 2021 at 5:51 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: > Hello Konstantin, > > On 1/7/21 7:16 PM, Konstantin Belousov wrote: > > On Thu, Jan 07, 2021 at 09:24:14AM +0000, Mateusz Piotrowski wrote: > >> The branch main has been updated by 0mp (doc, ports committer): > >> > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=74bd20769706041108a573601cf0b61c755bdc56 > >> > >> commit 74bd20769706041108a573601cf0b61c755bdc56 > >> Author: Mateusz Piotrowski <0mp@FreeBSD.org> > >> AuthorDate: 2021-01-07 09:22:20 +0000 > >> Commit: Mateusz Piotrowski <0mp@FreeBSD.org> > >> CommitDate: 2021-01-07 09:24:07 +0000 > >> > >> Reference newfs_msdos(8) from the newfs(8) manual > > Why ? newfs is not the interface to create arbitrary kind of filesystem, > > it is just UFS writer. > > I think that it is beneficial nevertheless. Now users can discover other > newfs_* commands FreeBSD > offers. Also, newfs_msdos(8) already references newfs(8) (there are only > two items in the SEE ALSO > section there, the other one being gpart(8)). > > From my perspective it is not too bad to have this reference in the newfs > manual. It seems like > it's also something some FreeBSD users expect to see in the manual page as > we received a bug report > for that. > > I can revert this patch and also remove newfs(8) from the newfs_msdos > manual while at it if desired. > Perhaps newfs commands are easy enough to find so this patch only hurts > the readability of the manual... > I think it's a good change because many other filesystem manipulation commands will do arbitrary filesystems. Since it breaks this symmetry, having the xref is fine. Warner