Date: Fri, 6 Jul 2012 18:11:56 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r238172 - head/sys/dev/agp Message-ID: <CCAB16B3-975C-4E0A-A7D5-26309D155C59@xcllnt.net> In-Reply-To: <20120706181213.GI2338@deviant.kiev.zoral.com.ua> References: <201207061557.q66Fv45N069464@svn.freebsd.org> <20120706181213.GI2338@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 6, 2012, at 11:12 AM, Konstantin Belousov wrote: >> agp_i810.c: >> While arguably the use of Maxmem can be considered correct, replace = its use >> with realmem anyway. agp_i810.c is specific to amd64, i386 & pc98, = which >> have a dense physical memory layout. Avoiding Maxmem here is done = with an >> eye on copy-n-paste behaviour in general and to avoid confusion = caused by >> using realmem in agp.c and Maxmem in agp_i810.c. > The agp_i810.c use is to prevent attachment when largest physical = address > of populated memory exceeds GPU limits established by PTE format and > chipset errata. Editing Maxmem to be spelled as realmem seems to = change > nothing right now, but I do argue that this is wrong, and commit = message > makes future archeology quite confusing. The commit log states it all, including how one can arguably call the = change wrong. What exactly is confusing? --=20 Marcel Moolenaar marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CCAB16B3-975C-4E0A-A7D5-26309D155C59>