Date: Fri, 25 May 2001 11:13:58 +1000 From: Benno Rice <benno@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org> Cc: Doug Rabson <dfr@nlsystems.com>, freebsd-ppc@FreeBSD.org Subject: Re: FreeBSD/powerpc work to date Message-ID: <20010525111357.B90363@rafe.jeamland.net> In-Reply-To: <20010524175339.A13912@dragon.nuxi.com>; from obrien@FreeBSD.org on Thu, May 24, 2001 at 05:53:39PM -0700 References: <20010521234812.B56326@rafe.jeamland.net> <Pine.BSF.4.33.0105221534590.46007-100000@herring.nlsystems.com> <20010523101643.A70899@rafe.jeamland.net> <20010524175339.A13912@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--mojUlQ0s9EVzWg2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 24, 2001 at 05:53:39PM -0700, David O'Brien wrote: > On Wed, May 23, 2001 at 10:16:43AM +1000, Benno Rice wrote: > > > Nice! Reading through the changes, I have a couple of comments. In > > > mp_machdep.c, you should remove the 'include <machine/rpb.h>' - that = is > > > only ever likely to exist on alpha. You can alsp delete ipl.h since t= hat > > > has been removed for the other arches. > >=20 > > Ah. I started with the code from NetBSD and pulled bits from around the > > tree to fill gaps, so there's some weirdness in there. =3D) >=20 > I would rather not see things with NetBSD weirdness we do not understand > committed. Otherwise these bits will last forever and we'll have a > platform who's code smells different from the other smelling two we > already have. There's already some NetBSDisms in alpha, since (IIRC) it took pretty much the same path. I left the NetBSD stuff there in case I need to refer to it while writing/changing the code to support FreeBSD. > I cannot tell from your reply if you are going to act on DFR's issue. > You only explained the why, not what you plan to do about it. I plan to leave it there until the code is obsolete basically. Once I have a piece of code that works, I'll delete the NetBSD code (unless of course that code's used =3D)). > > > In swtch.s, you are correct in thinking that Idle is unneeded. A gene= ric > > > assembler question - why the use of _C_LABEL(xx)? Surely since we are= only > > > ever going to be using ELF here, we can assume the format of C names?= Its > > > difficult to see what is happening since I'm not familiar with powerpc > > > assembler but it appears that you are saving the process state on the > > > stack (using a 'struct switchframe'). The other architectures save th= is > > > information in the PCB - I'm not sure which is the best place. > >=20 > > This is probably NetBSD code. Since I haven't got that far yet, it's p= retty > > much unchanged except that I separated their locore.s into smaller file= s as > > per the other FreeBSD ports. >=20 > See my concerns above. I especially feel this way about strange > macros. Those of us reading both Alpha and x86 headers often have to > scratch our heads what these NetBSD macros do, etc.. I agree, I'm just trying to get it working as the time I can spend on this = is limited. My plan is to get it to a point, probably single-user, then start a big clean up to cut out unused and/or unneeded code and make sure the code's all adhering to style(9) and has comments and suchlike. --=20 Benno Rice benno@FreeBSD.org --mojUlQ0s9EVzWg2t Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjsNsdUACgkQbQx7xhW+Eg4qQQCg0YZlncpmLLYmsO0WTY15i+yZ lrUAoIFwkk/ycJNlty+x23rVlol6PoHQ =12x5 -----END PGP SIGNATURE----- --mojUlQ0s9EVzWg2t-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ppc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010525111357.B90363>