Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 05 Feb 2023 07:00:27 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Dave Cottlehuber <dch@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: 7efc3219b149 - main - lang/zig: build for lowest common denominator CPU
Message-ID:  <r0v4-1wjo-wny@FreeBSD.org>
In-Reply-To: <202302042328.314NSukx018262@gitrepo.freebsd.org> (Dave Cottlehuber's message of "Sat, 4 Feb 2023 23:28:56 GMT")
References:  <202302042328.314NSukx018262@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Dave Cottlehuber <dch@FreeBSD.org> writes:

> +CMAKE_ARGS+=	-DZIG_TARGET_MCPU=baseline # ensure we run everywhere

Why did you ignore CPUTYPE suggestion by diizzy@ in review?
"native" is still useful when building zig itself locally.

See also https://cgit.freebsd.org/ports/commit/?id=96dff11bed89

diff --git a/lang/zig/Makefile b/lang/zig/Makefile
index 0b72faae67d6..5b53d19561cb 100644
--- a/lang/zig/Makefile
+++ b/lang/zig/Makefile
@@ -28,7 +28,7 @@ LIB_DEPENDS=	liblzma.so:archivers/lzma \
 
 USES=		cmake compiler:c++11-lang localbase:ldflags tar:xz
 CMAKE_ON=	THREADS_PREFER_PTHREAD_FLAG
-CMAKE_ARGS+=	-DZIG_TARGET_MCPU=baseline # ensure we run everywhere
+CMAKE_ARGS=	-DZIG_TARGET_MCPU="${CPUTYPE:Ubaseline}"
 
 OPTIONS_DEFINE=		DOCS STATIC
 OPTIONS_DEFAULT=	DOCS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?r0v4-1wjo-wny>