Date: Wed, 3 Apr 2024 08:52:31 +0300 From: Matthias Fechner <mfechner@freebsd.org> To: Yasuhiro Kimura <yasu@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 81b6dcb645ee - main - databases/redis*: Refine ports Message-ID: <fc5c3855-c4ef-4801-a5ee-6b46931bb958@freebsd.org> In-Reply-To: <20240403.140025.226010735618620137.yasu@FreeBSD.org> References: <202404030436.4334aLaq011132@gitrepo.freebsd.org> <9e19fb02-7aeb-48ad-a999-5f626200e755@freebsd.org> <20240403.140025.226010735618620137.yasu@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------apwHfWsgcIRcd2Qn3V9lD9Th
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Am 03.04.2024 um 08:00 schrieb Yasuhiro Kimura:
> From: Matthias Fechner<mfechner@freebsd.org>
> Subject: Re: git: 81b6dcb645ee - main - databases/redis*: Refine ports
> Date: Wed, 3 Apr 2024 07:50:14 +0300
>
>> Am 03.04.2024 um 07:36 schrieb Yasuhiro Kimura:
>>
>>> * Pet portclippy.
>> just to learn something new, what is portclippy?
>>
>> Gruß
>> Matthias
> It is installed with ports-mgmt/portfmt and checks the order of
> variables in Makefie. I use it as following.
>
> % cd /usr/port/category/name
> % portclippy Makefile | diff -u Makefile -
amazing, thanks a lot Yasuhiro. I added this now to my gitlab pipeline,
so it run automatically in my tests.
If someone is interested:
# make sure package ports-mgmt/portfmt is installed to have portclippy
available
portclippy:
stage: test
needs: [ ]
allow_failure: true
script:
- git diff-tree --no-commit-id --name-only -r
origin/$CI_DEFAULT_BRANCH $CI_COMMIT_SHA | grep -E '.*/.*/Makefile$' |
sort -u | xargs -tL 1 portclippy
rules:
- if: $CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH
In this way, I just do my commits in a branch different to the default
branch push the changes and check the pipeline, if everything is fine,
merge the branch and push it to the FreeBSD repo.
Gruß
Matthias
--
"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
--------------apwHfWsgcIRcd2Qn3V9lD9Th
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Am 03.04.2024 um 08:00 schrieb Yasuhiro
Kimura:<br>
</div>
<blockquote type="cite"
cite="mid:20240403.140025.226010735618620137.yasu@FreeBSD.org">
<pre class="moz-quote-pre" wrap="">From: Matthias Fechner <a class="moz-txt-link-rfc2396E" href="mailto:mfechner@freebsd.org"><mfechner@freebsd.org></a>
Subject: Re: git: 81b6dcb645ee - main - databases/redis*: Refine ports
Date: Wed, 3 Apr 2024 07:50:14 +0300
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Am 03.04.2024 um 07:36 schrieb Yasuhiro Kimura:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">* Pet portclippy.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
just to learn something new, what is portclippy?
Gruß
Matthias
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
It is installed with ports-mgmt/portfmt and checks the order of
variables in Makefie. I use it as following.
% cd /usr/port/category/name
% portclippy Makefile | diff -u Makefile -
</pre>
</blockquote>
amazing, thanks a lot Yasuhiro. I added this now to my gitlab
pipeline, so it run automatically in my tests.<br>
If someone is interested:<br>
<div
style="color: #2e2e2e;background-color: #ffffff;font-family: 'GitLab Mono', JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospace, Consolas, 'Courier New', monospace;font-weight: normal;font-size: 14px;line-height: 19px;white-space: pre;"><div><span
style="color: #999988;font-style: italic;"># make sure package ports-mgmt/portfmt is installed to have portclippy available</span></div><div><span
style="color: #2e2e2e;">portclippy:</span></div><div><span
style="color: #2e2e2e;"> stage: </span><span
style="color: #dd1144;">test</span></div><div><span
style="color: #2e2e2e;"> needs: [ ]</span></div><div><span
style="color: #2e2e2e;"> allow_failure: </span><span
style="color: #2e2e2e;font-weight: bold;">true</span></div><div><span
style="color: #2e2e2e;"> script:</span></div><div><span
style="color: #2e2e2e;"> - </span><span style="color: #dd1144;">git diff-tree --no-commit-id --name-only -r origin/$CI_DEFAULT_BRANCH $CI_COMMIT_SHA | grep -E '.*/.*/Makefile$' | sort -u | xargs -tL 1 portclippy</span></div><div><span
style="color: #2e2e2e;"> rules:</span></div><div><span
style="color: #2e2e2e;"> - if: </span><span
style="color: #dd1144;">$CI_COMMIT_BRANCH != $CI_DEFAULT_BRANCH</span></div><div>
</div><div>In this way, I just do my commits in a branch different to the default branch push the changes and check the pipeline, if everything is fine, merge the branch and push it to the FreeBSD repo.</div></div>
<pre class="moz-signature" cols="72">
Gruß
Matthias
--
"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
</pre>
</body>
</html>
--------------apwHfWsgcIRcd2Qn3V9lD9Th--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fc5c3855-c4ef-4801-a5ee-6b46931bb958>