From owner-svn-src-head@FreeBSD.ORG  Thu Jul 10 16:05:11 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from ptrcrt.ch (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2123E89F;
 Thu, 10 Jul 2014 16:05:09 +0000 (UTC)
Date: Thu, 10 Jul 2014 18:05:06 +0200
From: Pietro Cerutti <gahr@FreeBSD.org>
To: Ed Schouten <ed@80386.nl>
Subject: Re: svn commit: r268491 - head/usr.bin/users
Message-ID: <20140710160506.GH1812@ptrcrt.ch>
Reply-To: gahr@FreeBSD.org
References: <201407101215.s6ACF3v1055260@svn.freebsd.org>
 <CAJOYFBCQjjN7ep12zivnmFjfeeP1SeoYa963mQbMJr9DD+fUnw@mail.gmail.com>
 <20140710152353.GF1812@ptrcrt.ch>
 <CAJOYFBDZiEpQ5e86+dBhRZobSjdf785bKBwh+3Eywhzn_iJJCQ@mail.gmail.com>
 <20140710154213.GG1812@ptrcrt.ch>
 <20140710155342.GB93051@ivaldir.etoilebsd.net>
 <CAJOYFBCMtnrdM96H9F86UsU=-7w-97N+KdBqYGihugD3W0+rbA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="N8ia4yKhAKKETby7"
Content-Disposition: inline
In-Reply-To: <CAJOYFBCMtnrdM96H9F86UsU=-7w-97N+KdBqYGihugD3W0+rbA@mail.gmail.com>
X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8  6D49 ADD0 D38E A192 089E";
 id="0xA192089E";
 get=<hkp://pgp.mit.edu/pks/lookup?search=0xADD0D38EA192089E&op=get>;
 get=<https://keyserver.pgp.com/vkd/DownloadKey.event?keyid=0xADD0D38EA192089E>;
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jul 2014 16:05:11 -0000


--N8ia4yKhAKKETby7
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2014-Jul-10, 17:57, Ed Schouten wrote:
> On 10 July 2014 17:53, Baptiste Daroussin <bapt@freebsd.org> wrote:
> > Just make sure not to break mips, powerpc and sparc64 which are still u=
sing
> > gcc 4.2 :)
>=20
> Oomf! Good point. Completely forgot about that. There is indeed one
> C++11-ism in the code, namely the use of auto. Let me fix that.

I reply to this one, since I'm not on src-all.

- for consistency, I'd s|std::set|set|
- return (0) is not needed in c++

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--N8ia4yKhAKKETby7
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJTvrmxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB
REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgieDS8QALFC7/80GkykoU9EuWJvTNas
CdTHkd/I9dPYz8+ApPf6QoraP/M8ZXp5e7H7lD+jOoaPwASFMq4KnvDcPXjgDOGb
wrw0YY4MyluhoepLYNK0VsFfBOA4gDBoyCVf/r5lsoBc/PGNnuc5acqN2B20Jlpm
Q79sXAR+joEjpP6Kecbv0taC9EqxzV+Zr4/cJwNj5CxGAMLKlqvYtIAFe7skfQ3n
xEHQK9ZKiO1+TXMGLBroAEQPZDEXqx5F8AK+gCJmsl/3oqOtwHVJimpl5TCT+QBD
az3trb0yzTy8RiUvtF6OpYhYediK+SvK458ficPJ/azbal6iWyB6bkFuBh7anDpV
4H0P7vC80OuM/Opay4UARlFhAhFT5CledGellPBLGi/LRc0DT35keIdnngYeFuv2
xBRdcq5QfPBuJYXoEBcmk2hPrvbfrWGrPfSJr6yMthXL4eZ6bFC3hSry42I7zhjF
nszi23UflixRIouc3owNPUGRzVG2ZIc/NeXUkVxWa9sdZNEijmCo7JB8l8ZvX61h
JioF0EBMHOwyDEn8OVh1jrPrllMuFKPiBOFUHy1CW12C0BqPqjAKkbhfvOw9dWWF
vkEOpxnx6p/PDQ7fJowkIsAB0fwDRcPDCt9NcePYd1DJ5/oRjRDIUftnE+W6ZR1B
KL6uDKHKA7ZaHoeMgM6t
=3ioi
-----END PGP SIGNATURE-----

--N8ia4yKhAKKETby7--