From owner-cvs-usrbin Mon Oct 7 10:52:55 1996 Return-Path: owner-cvs-usrbin Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id KAA14143 for cvs-usrbin-outgoing; Mon, 7 Oct 1996 10:52:55 -0700 (PDT) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id KAA14065; Mon, 7 Oct 1996 10:52:29 -0700 (PDT) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id TAA04469; Mon, 7 Oct 1996 19:52:22 +0200 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id TAA13183; Mon, 7 Oct 1996 19:52:17 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.7.5/8.6.9) id TAA14992; Mon, 7 Oct 1996 19:42:23 +0200 (MET DST) From: J Wunsch Message-Id: <199610071742.TAA14992@uriah.heep.sax.de> Subject: Re: cvs commit: src/usr.bin/su su.c To: wosch@cs.tu-berlin.de (Wolfram Schneider) Date: Mon, 7 Oct 1996 19:42:23 +0200 (MET DST) Cc: joerg@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-usrbin@freefall.freebsd.org In-Reply-To: <199610071118.NAA11594@caramba.cs.tu-berlin.de> from Wolfram Schneider at "Oct 7, 96 01:18:44 pm" X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-usrbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Wolfram Schneider wrote: > > Export $TERM only if it has been set in our environment. > > BTW, setenv(3) should not core if the second argument is a NULL > pointer. It should print a warning ("silly programmer error, cannot > set variable XYZ in function setenv(3)") and return. A coredump is a perfectly valid complaint at a stupid programmer. We already decided to prefer this method over wasting time at other occurences, e.g. by not allowing ``strcmp(foobar, NULL)'' etc. I don't see where the setenv() case is different. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)