From owner-svn-src-head@FreeBSD.ORG Sun Jan 22 03:43:39 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 694A6106566C; Sun, 22 Jan 2012 03:43:39 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id DF4948FC15; Sun, 22 Jan 2012 03:43:38 +0000 (UTC) Received: by vbbey12 with SMTP id ey12so1882394vbb.13 for ; Sat, 21 Jan 2012 19:43:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=X/KwV8Gyc+oK4exm3IoY0WLOKf/UAWc8Me6qkmFS4pw=; b=GBhUGNoTfJZXh5xEvn9mTvAtXeQ7OcIosuDcFJI16lGf7b0O9LuQ8drVW9PSxbZ7R3 9TeCRZ34vMOvSbJ4XlM+idE6aL6PkcSFMB7fznF7xQ0Twrbba3d/C8mp3agBbCpInlRG K3xEqe+S6F4yqI3Dp5nFu74zss2OoDPJku934= MIME-Version: 1.0 Received: by 10.52.94.33 with SMTP id cz1mr1554153vdb.132.1327203818151; Sat, 21 Jan 2012 19:43:38 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Sat, 21 Jan 2012 19:43:38 -0800 (PST) In-Reply-To: References: <201201210038.q0L0cJac066145@svn.freebsd.org> Date: Sat, 21 Jan 2012 19:43:38 -0800 X-Google-Sender-Auth: jdlM9U85oK5qcQ6GWFh19fhwMzE Message-ID: From: Adrian Chadd To: Rui Paulo Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230408 - head/sys/net80211 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jan 2012 03:43:39 -0000 On 20 January 2012 18:41, Rui Paulo wrote: > This commit doesn't help much and keeps us more toolchain dependent like > Alexander pointed out in IRC. Since ether_sprintf() wasn't causing any > trouble, please consider backing this out. > > This commit also introduces unnecessary changes which make reviewing > harder. > Hi, I'd like to eventually move away from doing it this way. The trouble is using ether_sprintf() multiple times (and even from multiple threads?) in the same debug statement results in non-useful behaviour. What I'm likely going to do is introduce an ether_ssprintf() which takes a char/len buffer to write into. That way the debug statements can just use that (with appropriate wrappers around them to only call ether_ssprintf() if the debug condition is met, otherwise unused sprintf()s will occur. I'm open to other suggestions though! Adrian