From owner-freebsd-audit Tue Jun 4 16:47:17 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 2356A37B406; Tue, 4 Jun 2002 16:47:14 -0700 (PDT) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g54NlBI8570274; Tue, 4 Jun 2002 19:47:12 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020605083335.T5376-100000@gamplex.bde.org> References: <20020605083335.T5376-100000@gamplex.bde.org> Date: Tue, 4 Jun 2002 19:47:10 -0400 To: Bruce Evans , Alexander Leidinger From: Garance A Drosihn Subject: Re: [PATCH] making dump EINTR resistant Cc: audit@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 8:43 AM +1000 6/5/02, Bruce Evans wrote: >On Tue, 4 Jun 2002, Alexander Leidinger wrote: >> > > The attached diff is against -current. >> >> Comments? > >read(), etc., are supposed to be restarted after signals, so >the EINTR checks should have no effect in most cases. > Would it be acceptable to add EINTR-type checks to freebsd-ish code? There are some sections of lpr/lpd which do not work right when compiled on other platforms, unless I add EINTR checks at the right places. Admittedly I haven't gone thru and figured out everyplace that should have those checks, I've just added them when I run into some system call which seems to get interrupted a lot. The present lpr code already includes *some* checks for EINTR, but I add a few more (when I compile lpr on other platforms...). Would it be reasonable to add those to the regular freebsd source for lpr? -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message