From owner-svn-src-head@freebsd.org Mon Aug 1 05:28:49 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8159BAB7EB; Mon, 1 Aug 2016 05:28:49 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 DV Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9639614E6; Mon, 1 Aug 2016 05:28:49 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from Xins-MBP.home.us.delphij.net (unknown [IPv6:2601:646:8880:a197:ed7f:1144:1649:8fde]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 64F741CC40; Sun, 31 Jul 2016 22:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1470029323; x=1470043723; bh=72AirEOq0HzaOFDCABxWZhFsHXKS9aT7BiZzV3vORDk=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=rFLjFes0zoacnA9qD9AwHLN0mU/edRX1RaG0aSjpIvTwY/qykFrjghRxGhVf2Q20M SiGSmpB1cIDNb8SVx7kbQL8CU9mDGlbpQdo7f0UVX99MDf8xisGutbv/YXUZRvy25t FTu+nACdmQ4dKKLkxPiLSFTwe+aWhwbL/tvmaJlM= Subject: Re: svn commit: r303600 - head/usr.bin/indent To: "Pedro F. Giffuni" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201607312136.u6VLaeRb058693@repo.freebsd.org> Cc: d@delphij.net From: Xin Li Message-ID: <8d6114b7-cd71-239a-dcc4-03a6d568482c@delphij.net> Date: Sun, 31 Jul 2016 22:28:38 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <201607312136.u6VLaeRb058693@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ibkdQuaLo4iB7j34Ll0K30K4it8V0osip" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 05:28:49 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ibkdQuaLo4iB7j34Ll0K30K4it8V0osip Content-Type: multipart/mixed; boundary="ow1a1EjppvvOJkjtFv0l3dEfG3XLHDJMw" From: Xin Li To: "Pedro F. Giffuni" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: d@delphij.net Message-ID: <8d6114b7-cd71-239a-dcc4-03a6d568482c@delphij.net> Subject: Re: svn commit: r303600 - head/usr.bin/indent References: <201607312136.u6VLaeRb058693@repo.freebsd.org> In-Reply-To: <201607312136.u6VLaeRb058693@repo.freebsd.org> --ow1a1EjppvvOJkjtFv0l3dEfG3XLHDJMw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 7/31/16 14:36, Pedro F. Giffuni wrote: > Author: pfg > Date: Sun Jul 31 21:36:40 2016 > New Revision: 303600 > URL: https://svnweb.freebsd.org/changeset/base/303600 >=20 > Log: > indent(1): replace function call to bzero with memset. > =20 > Reference: > https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833= d7106035dc09230235 > =20 > Differential Revision: https://reviews.freebsd.org/D6966 (Partial) > Submitted by: Piotr Stefaniak >=20 > Modified: > head/usr.bin/indent/io.c >=20 > Modified: head/usr.bin/indent/io.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/indent/io.c Sun Jul 31 21:29:10 2016 (r303599) > +++ head/usr.bin/indent/io.c Sun Jul 31 21:36:40 2016 (r303600) > @@ -629,7 +629,7 @@ parsefont(struct fstate *f, const char * > const char *s =3D s0; > int sizedelta =3D 0; > =20 > - bzero(f, sizeof *f); > + memset(f, 0, sizeof(struct fstate)); ^^^^^^^^^^^^^^^^^^^^^ This is much more error-prone than sizeof(*f) IMHO. Cheers, --ow1a1EjppvvOJkjtFv0l3dEfG3XLHDJMw-- --ibkdQuaLo4iB7j34Ll0K30K4it8V0osip Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJXnt4KAAoJEJW2GBstM+ns71oP+wZGaoyh1/leHqlrQ1ZGY66e PO0RWY+AZQBNqgoqvklQnv3UkPdkwHw19Or0QTziyRaG+PNpf4fZ7WRO53ycO2Ne AsdsjiIZpier2GfjOjSb25hQzc7Qt9tOYm3rNCUyaB9JndJKALcEq0cZczbRuqIk 6dwbqPXk91BkuNIbU78jtPkX0NNa9zBYRcTA8jqxQirn5HX/pVcA7WiIWF3azq9Q q43vNTY4J3+Pxsh0Hyekew/7UA1yI7oSkNy3MiQcYmua1Ag6rGnELGdh3kXJPXBG PCLXhK15BYFBM5RMP8z2ZR/VfIJSc2bsvpoA+uiut9U2PdaTgS3gj6rM5z3ZvCrz Sm08SwP2FvnhqqmXEu/gyxt2kDhQYb4gXVSl4GzeJU+FsEiHXfvw+svNDYlXUVwy qiEbXr4naXK+z6VdETgS2VTP1XmI1hHSy9K0d5r8jJOfhTIjvDroKp55NB5Adov8 80DvtNH/Ymic2RD2FHgsW4sh9RYeYSPlEssEfT5axJwuFIVwixD+K2ong8zInIMr KnnNWAek/XoAqPEQoJzjp81tFp5iLqOaTjVDxMIZBTGuSHfp0qFqgpRRom0wo8A0 +va5exdLtcQlHfyRyeH3qDWSoajNuSv+NJerVQBONTwYy8MlAMP5/v/jETtFb6e+ +WcboMomhRJ97Wm5Vn8M =orQq -----END PGP SIGNATURE----- --ibkdQuaLo4iB7j34Ll0K30K4it8V0osip--