From owner-freebsd-hackers@FreeBSD.ORG  Thu Nov  1 13:11:58 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C7FB727B;
 Thu,  1 Nov 2012 13:11:58 +0000 (UTC)
 (envelope-from alfred@ixsystems.com)
Received: from mail.iXsystems.com (newknight.ixsystems.com [206.40.55.70])
 by mx1.freebsd.org (Postfix) with ESMTP id A677F8FC16;
 Thu,  1 Nov 2012 13:11:58 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by mail.iXsystems.com (Postfix) with ESMTP id 15DA811F5;
 Thu,  1 Nov 2012 06:11:58 -0700 (PDT)
Received: from mail.iXsystems.com ([127.0.0.1])
 by localhost (mail.ixsystems.com [127.0.0.1]) (maiad, port 10024) with ESMTP
 id 48294-03; Thu,  1 Nov 2012 06:11:57 -0700 (PDT)
Received: from [10.0.1.22] (c-67-180-208-218.hsd1.ca.comcast.net
 [67.180.208.218])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.iXsystems.com (Postfix) with ESMTPSA id B9FD911F3;
 Thu,  1 Nov 2012 06:11:57 -0700 (PDT)
Message-ID: <5092751C.8060009@ixsystems.com>
Date: Thu, 01 Nov 2012 06:11:56 -0700
From: Alfred Perlstein <alfred@ixsystems.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:16.0) Gecko/20121026 Thunderbird/16.0.2
MIME-Version: 1.0
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
Subject: Re: please review: patch to retain device name for dumpdev.
References: <50921B44.20400@ixsystems.com>
 <14235.1351757200@critter.freebsd.dk>
In-Reply-To: <14235.1351757200@critter.freebsd.dk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Fri, 02 Nov 2012 02:54:03 +0000
Cc: mav@freebsd.org, hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2012 13:11:58 -0000

On 11/1/12 1:06 AM, Poul-Henning Kamp wrote:
> --------
> In message <50921B44.20400@ixsystems.com>, Alfred Perlstein writes:
>
>> Poul-Henning, what do you think?  Is there a nicer way?  Perhaps a way
>> to include the "/dev/$device"
> I think there are private implemenations where dumpdev is a network thing,
> so too much magic string editing is probably not a good idea.
>
> Given that /dev is really just a view into GEOMs namespace, one could
> argue for "GEOM:ada0p3" that that may be going overboard in sematic
> correctness.

Good point, thank you.  I'll leave the patch as-is.

-Alfred