Date: Thu, 01 Nov 2012 06:11:56 -0700 From: Alfred Perlstein <alfred@ixsystems.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: mav@freebsd.org, hackers@freebsd.org Subject: Re: please review: patch to retain device name for dumpdev. Message-ID: <5092751C.8060009@ixsystems.com> In-Reply-To: <14235.1351757200@critter.freebsd.dk> References: <50921B44.20400@ixsystems.com> <14235.1351757200@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/1/12 1:06 AM, Poul-Henning Kamp wrote: > -------- > In message <50921B44.20400@ixsystems.com>, Alfred Perlstein writes: > >> Poul-Henning, what do you think? Is there a nicer way? Perhaps a way >> to include the "/dev/$device" > I think there are private implemenations where dumpdev is a network thing, > so too much magic string editing is probably not a good idea. > > Given that /dev is really just a view into GEOMs namespace, one could > argue for "GEOM:ada0p3" that that may be going overboard in sematic > correctness. Good point, thank you. I'll leave the patch as-is. -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5092751C.8060009>