From owner-freebsd-net@freebsd.org Thu May 10 15:43:17 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F02D3FCE22B for ; Thu, 10 May 2018 15:43:16 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64D31765C3 for ; Thu, 10 May 2018 15:43:16 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: by mail-wm0-x22f.google.com with SMTP id w194-v6so4604584wmf.2 for ; Thu, 10 May 2018 08:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:references:in-reply-to:subject:date:message-id:mime-version :thread-index:content-language; bh=hyrqIBdbkctTquKAOYt3seK6/A6rqAqA2CS0Bj6RC7o=; b=rB6ewwCTV5bgVP92fha1jWUGPjHdOs84my1DE5qv+dsVOc9wRxAeZuwkeBbZtDfL5h UQtMREoAod51bNKIiSfjQbjOFYxh7jcR1blDgWEJJ5dihqi4iNBphEc+eIRXv2qBxKob dRaM4qf3l9unHJFCVFaR6SavYV6cSyE7ZuWJ/B57ujMIYyrgg2Yrg8UWVcytYkQ5UMRO X86eF7oalyEV/kcmxK+UlWqLJK/axsX8aAVSzBJMg42boFymaIwKndndTWmSMNf6QGFb PEOgYZVpstCVYfk+nothOFzuEt/gjkEilcZvKkCyYZPH5MriwsMv6jpEBVS5xHUVTCRB 2bUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:references:in-reply-to:subject:date :message-id:mime-version:thread-index:content-language; bh=hyrqIBdbkctTquKAOYt3seK6/A6rqAqA2CS0Bj6RC7o=; b=F9Zxt0QJ59EQ981MhSEIRKFJJsOL+UAYY21NUAP7iYmFAdHs28vdViR0u1bW5YZgfP LBuYvHYPl86iX22z8VsF3q/Q9ObPSh5vAz+pQwWAWs688aGWPKjpm6Rsv6rQnOjnjlhC YxADP3D1EugHcV7AZuNOmhLPJWd0uk/Oqryr46DQMcBwAmXef1qJqEL18EFnyT8DI26h 3qPsv+wlTO80HCgxLzJ6JHetwIM6eNsPskJnDvnOW4KdOMnBPcjporfZnkTYdsoU+5lt rWbLE6w49q5OdiI4L3KyUt5jIlHxYuB67Ynr1VTH5udiB+ZyWuinnAp+AdNggFG/586y i3uA== X-Gm-Message-State: ALKqPwed9CVDfKXcws5lGCOIgJag7Q2/TP8zAkxu/m7GmE/Q08Dj2SZ3 EFrxrBUlR18tDg/zHu0Pvv8= X-Google-Smtp-Source: AB8JxZoCmaRZtvaYVvS/u85Yh3MpHovm1dGGDv953L29T9Vl0e+7gqiJxGtDkQ0Hl9bI7GO39JNUcA== X-Received: by 2002:a50:ec16:: with SMTP id g22-v6mr2941786edr.242.1525966995402; Thu, 10 May 2018 08:43:15 -0700 (PDT) Received: from DriesPC (ptr-8sl34rf6ki9c3i8vpvf.18120a2.ip6.access.telenet.be. [2a02:1811:2515:e000:2d76:eb53:3cfc:54bb]) by smtp.gmail.com with ESMTPSA id j22-v6sm803929eda.72.2018.05.10.08.43.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 May 2018 08:43:14 -0700 (PDT) From: "Dries Michiels" To: "'Andrey V. Elsukov'" , References: <5ae60f44.1c69fb81.ee4a5.1043@mx.google.com> <008101d3e86f$584fb930$08ef2b90$@gmail.com> In-Reply-To: <008101d3e86f$584fb930$08ef2b90$@gmail.com> Subject: RE: kernel: in6_delayed_cksum: delayed m_pullup Date: Thu, 10 May 2018 17:43:13 +0200 Message-ID: <012401d3e875$9bd23a60$d376af20$@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0125_01D3E886.5F5BA6A0" X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQH3wx2RQj7VP9hMd2oXN/9H7zga9gKJLk47AUTkTl4BtUDeo6O1R6sg Content-Language: nl-be X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 May 2018 15:43:17 -0000 This is a multipart message in MIME format. ------=_NextPart_000_0125_01D3E886.5F5BA6A0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Dries Michiels > Sent: donderdag 10 mei 2018 16:58 > To: 'Andrey V. Elsukov' ; freebsd-net@freebsd.org > Subject: RE: kernel: in6_delayed_cksum: delayed m_pullup >=20 > > -----Original Message----- > > From: Andrey V. Elsukov > > Sent: donderdag 10 mei 2018 16:34 > > To: Dries Michiels ; > > freebsd-net@freebsd.org > > Subject: Re: kernel: in6_delayed_cksum: delayed m_pullup > > > > On 10.05.2018 17:25, Andrey V. Elsukov wrote: > > > On 29.04.2018 21:30, Dries Michiels wrote: > > >> Dear mailing list, > > >> > > >> After upgrading my FreeBSD server from source from: > > >> FreeBSD 11.1-STABLE (VADOS) #9 r331859: Sun Apr 1 12:09:18 CEST > > >> 2018 to FreeBSD 11.2-PRERELEASE (VADOS) #10 r333091: Sun Apr 29 > > >> 16:48:44 CEST 2018 > > >> > > >> My /var/log/messages is getting spammed by the following > notice/error: > > >> Apr 29 19:51:42 vados kernel: in6_delayed_cksum: delayed = m_pullup, > > >> m->len: 48 plen 68 off 56 csum_flags=3D400 Apr 29 > > >> 19:55:34 vados last message repeated 11 times Apr 29 20:11:56 = vados > > >> last message repeated 10 times Apr 29 20:12:42 vados last message > > >> repeated 4 times > > >> > > >> Does anyone have a clue what this indicates? > > >> I did not have this message on my older system (r331859). > > > > > > Do you use pf(4) or ipsec(4)? >=20 > I use IPFW as firewall. Due to log file spamming I had disabled ipv6. > I will enable it again and check if error message is still present. > If so I will try the patch you provided. Thanks in advance! > > Also, can you try this patch? > > > > -- > > WBR, Andrey V. Elsukov Ok error has returned: May 10 17:31:39 vados kernel: in6_delayed_cksum: delayed m_pullup, = m->len: 48 plen 68 off 56 csum_flags=3D400 May 10 17:31:53 vados last message repeated 3 times I'll apply the patch and rebuild from source to give an update later. Dries ------=_NextPart_000_0125_01D3E886.5F5BA6A0 Content-Type: application/octet-stream; name="in6_delayed_cksum.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="in6_delayed_cksum.diff" Index: sys/netinet6/ip6_output.c =================================================================== --- sys/netinet6/ip6_output.c (revision 333460) +++ sys/netinet6/ip6_output.c (working copy) @@ -199,18 +199,10 @@ in6_delayed_cksum(struct mbuf *m, uint32_t plen, u csum = 0xffff; offset += m->m_pkthdr.csum_data; /* checksum offset */ - if (offset + sizeof(u_short) > m->m_len) { - printf("%s: delayed m_pullup, m->len: %d plen %u off %u " - "csum_flags=%b\n", __func__, m->m_len, plen, offset, - (int)m->m_pkthdr.csum_flags, CSUM_BITS); - /* - * XXX this should not happen, but if it does, the correct - * behavior may be to insert the checksum in the appropriate - * next mbuf in the chain. - */ - return; - } - *(u_short *)(m->m_data + offset) = csum; + if (offset + sizeof(csum) > m->m_len) + m_copyback(m, offset, sizeof(csum), (caddr_t)&csum); + else + *(u_short *)mtodo(m, offset) = csum; } int ------=_NextPart_000_0125_01D3E886.5F5BA6A0--