Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Aug 2019 15:09:00 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        Kirill Ponomarev <krion@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r510145 - head/sysutils/screen
Message-ID:  <20190829130900.7qqm5rv3z3zgnmdw@ivaldir.net>
In-Reply-To: <201908291254.x7TCsFCI051889@slippy.cwsent.com>
References:  <201908290638.x7T6cVFc033808@repo.freebsd.org> <201908291230.x7TCUgKI027625@slippy.cwsent.com> <20190829124225.r7gpumnvtbeguuoz@ivaldir.net> <201908291254.x7TCsFCI051889@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--7q7fcany5dwqokun
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 29, 2019 at 05:54:15AM -0700, Cy Schubert wrote:
> In message <20190829124225.r7gpumnvtbeguuoz@ivaldir.net>, Baptiste=20
> Daroussin wr
> ites:
> >=20
> >
> > --vmfceac25l47d6el
> > Content-Type: text/plain; charset=3Dus-ascii
> > Content-Disposition: inline
> > Content-Transfer-Encoding: quoted-printable
> >
> > On Thu, Aug 29, 2019 at 05:30:42AM -0700, Cy Schubert wrote:
> > > In message <201908290638.x7T6cVFc033808@repo.freebsd.org>, Kirill Pon=
omar=3D
> > ev=3D20
> > > wri
> > > tes:
> > > > Author: krion
> > > > Date: Thu Aug 29 06:38:31 2019
> > > > New Revision: 510145
> > > > URL: https://svnweb.freebsd.org/changeset/ports/510145
> > > >
> > > > Log:
> > > >   Remove building man page by default. It's currently broken on HEAD
> > > >   and requires to build textproc/groff which requires devel/llvm80
> > > >   which is an overkill for using screen.
> > > >
> > > > Modified:
> > > >   head/sysutils/screen/Makefile
> > > >
> > > > Modified: head/sysutils/screen/Makefile
> > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
> > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
> > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=
=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D
> > =3D3D=3D3D=3D3D=3D3D
> > > > =3D3D
> > > > --- head/sysutils/screen/Makefile	Thu Aug 29 06:37:17 2019	(r51014
> > > > 4)
> > > > +++ head/sysutils/screen/Makefile	Thu Aug 29 06:38:31 2019	(r51014
> > > > 5)
> > > > @@ -3,7 +3,7 @@
> > > > =3D20
> > > >  PORTNAME=3D3D	screen
> > > >  PORTVERSION=3D3D	4.6.2
> > > > -PORTREVISION=3D3D	1
> > > > +PORTREVISION=3D3D	2
> > > >  CATEGORIES=3D3D	sysutils
> > > >  MASTER_SITES=3D3D	GNU \
> > > >  		ftp://ftp.gnu.org/gnu/screen/ \
> > > > @@ -20,7 +20,7 @@ COMMENT=3D3D	Multi-screen window manager
> > > >  LICENSE=3D3D	GPLv3
> > > > =3D20
> > > >  OPTIONS_DEFINE=3D3D		INFO MAN NETHACK XTERM_256 SHOWENC SYST
> > EM_SCREE
> > > > NRC
> > > > -OPTIONS_DEFAULT=3D3D	INFO MAN NETHACK XTERM_256 SOCKETS SYSTEM_SCR=
EE
> > NRC \
> > > > +OPTIONS_DEFAULT=3D3D	INFO NETHACK XTERM_256 SOCKETS SYSTEM_SCREENR=
C=20
> > \
> > > >  			NCURSES_DEFAULT
> > > >  OPTIONS_SINGLE=3D3D		IPC NCURSES
> > > >  OPTIONS_SINGLE_IPC=3D3D	SOCKETS NAMED_PIPES
> > > >
> > >=3D20
> > > Should you not have obtained maintainer approval for this first?
> > >=3D20
> > > And now the package will not include man pages. Can I assign those PR=
s to=3D
> > =3D20
> > > you?
> > >=3D20
> >
> > I do think the best approach to this is to drop the MAN page option, it=
 mak=3D
> > es
> > little sense not to install it. and not add groff as a runtime dependen=
cy
> > anyway.
>=20
> I've had this same issue with krb5. Pkg end users expect man pages.
>=20
> >
> > The reason why man(1) is telling the users to install groff(1) is exact=
ly f=3D
> > or
> > that, the users do decide if he wants to read that manpage on his syste=
m an=3D
> > d do
> > install groff, or he reads it online and do not install it at all. the =
other
> > point is in the future screen(1) might become mandoc compatible. and yo=
u wi=3D
> > ll
> > still grab in the groff(1) dependency.
>=20
> I'm willing to live with this but it is still disrespectful not to involv=
e=20
> the maintainer.
>=20
> Can I point to this email thread as a precedent if or when I commit to a=
=20
> port maintained by someone else?

For sure the maintainer should have been involved! and also my proposal if
different from what has been done here. ;)

Best regards,
Bapt

--7q7fcany5dwqokun
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl1nzmUACgkQY4mL3PG3
PlqiTw//YImmBey5/FtlXumGbtMpIbr0qtDNMGEhrF9950SemqaQ3+FG8V7euzf5
DDaO62S91Much8C1Xp/kWpOfAqlt5Q01clsjQ8wwyaaNyrqyzXy/Eqftu1fsKSzL
EBRpAZe47SkiW1woxhLHHvW+FBvFWYeto0y42D5OWkxdfQGGMl8j/XavNqmPoZ2R
CWHvCI7gpIzCo1vbkspSkVyzJ/okHrQ//gO60/8focXfPgeKqHnPiQgssUhK72wH
BSWxchGCHSD4ycb+htQIXUTStNR0WzHpvbqayiFteu/0L6KLbsKsdAj8utsiRiY3
2QGSOQIA2FlMVDn9qLA4akPudDsY/4YFkyxtnI8MV5Irm6zlFy7IDqjTBx+wHL3e
Qv73dbGZOq1kKa64KYohjX4W43wNDN1HOdb1/b9HkvDQGg+vSuGvxNsf4A9InX+d
D7DcP1q2zjxN7/05laWDjuoyxnnoc/yFPIltXxZJLjzWuw6mXXw+TsQzXBoYbmkj
kIPlUUE6+ndsVKd/iMMQgL6f+LO43X/LiKe3J4mGdGseXtUasRQWKDpB6HIFzt9V
to/R2N1pvYhtJhGG0OQgubkJ0YfvBrmHmlmKuHLlVHofR+yGkOyaNsXEjAkkfQRk
XtKVqoRGexzBvsyqVFKEhDeEofOMHxnn+6ESiz0Wx/njm/ljKQE=
=SfvM
-----END PGP SIGNATURE-----

--7q7fcany5dwqokun--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190829130900.7qqm5rv3z3zgnmdw>