From owner-freebsd-current  Wed May 24  8:20:56 2000
Delivered-To: freebsd-current@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP id 82B4437BCB6
	for <current@FreeBSD.ORG>; Wed, 24 May 2000 08:20:51 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id BAA00958;
	Thu, 25 May 2000 01:20:09 +1000
Date: Thu, 25 May 2000 01:20:05 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: Jake Burkholder <jburkhol@home.com>,
	Chuck Robey <chuckr@picnic.mat.net>,
	FreeBSD-current <current@FreeBSD.ORG>
Subject: Re: HEADS UP Re: cvs commit: src/crypto/openssh/pam_ssh pam_ssh.c 
 src/gnu/usr.bin/binutils/gdb freebsd-uthread.c src/include mpool.h 
 src/lib/libc/net name6.c src/lib/libc_r/uthread pthread_private.h  uthread_file.c
 src/lib/libncp ncpl_rcfile.c src/lib/libstand if_ether.h ...
In-Reply-To: <200005241435.KAA60183@khavrinen.lcs.mit.edu>
Message-ID: <Pine.BSF.4.21.0005250102020.2774-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Wed, 24 May 2000, Garrett Wollman wrote:

> <<On Tue, 23 May 2000 20:27:10 -0700, Jake Burkholder <jburkhol@home.com> said:
> 
> > I've just built a fresh world here; if you use the cvs-crypto from
> > internat, it may be broken.  I submitted a patch to Mark Murray which
> > should fix it, here it is again just in case:
> 
> I still think (and am going on record) that this is a REALLY, REALLY
> BAD idea.

Especially since most of the queue macros require the type to be a struct
to work.  E.g.:

#define	SLIST_REMOVE(head, elm, type, field) do {			\
                                ^^^^ a supposedly general type
	if (SLIST_FIRST((head)) == (elm)) {				\
		SLIST_REMOVE_HEAD((head), field);			\
	}								\
	else {								\
		type *curelm = SLIST_FIRST((head));			\
		while (SLIST_NEXT(curelm, field) != (elm))		\
		       ^^^^^^^^^^^^^^^^^^^^^^^^^

I objected to a recent commit hiding the fact that this is
"(elm)->field.sle_next".  Anyway, curelm must be a pointer to a struct.
Not just any struct; the struct must contain a "field" declared using
SLIST_ENTRY().

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message