From owner-cvs-all@FreeBSD.ORG  Thu Feb 26 21:21:42 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3C04D16A4CE; Thu, 26 Feb 2004 21:21:42 -0800 (PST)
Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1AAA843D31; Thu, 26 Feb 2004 21:21:42 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org
	(d37121b29acff5829e26e06b5b19cb68@adsl-67-119-53-203.dsl.lsan03.pacbell.net
	[67.119.53.203])i1R5LdX0001736;	Thu, 26 Feb 2004 21:21:40 -0800 (PST)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id 98EF766CAF; Thu, 26 Feb 2004 21:21:39 -0800 (PST)
Date: Thu, 26 Feb 2004 21:21:39 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Peter Schultz <pmes@bis.midco.net>
Message-ID: <20040227052139.GA13312@xor.obsecurity.org>
References: <200402251000.i1PA0nGn056196@repoman.freebsd.org>
	<403E0B90.9040106@bis.midco.net> <20040226203351.GB5915@xor.obsecurity.org>
	<403EA170.9080100@bis.midco.net> <20040227015101.GA10403@xor.obsecurity.org>
	<403EAF98.7080009@bis.midco.net> <20040227031312.GA11697@xor.obsecurity.org>
	<403EB9C5.3020108@bis.midco.net> <20040227033527.GA12083@xor.obsecurity.org>
	<403ED260.1060707@bis.midco.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5"
Content-Disposition: inline
In-Reply-To: <403ED260.1060707@bis.midco.net>
User-Agent: Mutt/1.4.1i
cc: ports-committers@FreeBSD.org
cc: jkoshy@FreeBSD.org
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: cvs commit: ports/graphics/xaos Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2004 05:21:42 -0000


--bg08WKrSYDhXBjb5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 26, 2004 at 11:15:12PM -0600, Peter Schultz wrote:
> Kris Kennaway wrote:
> >On Thu, Feb 26, 2004 at 09:30:13PM -0600, Peter Schultz wrote:
> >
> >>Kris Kennaway wrote:
> >>
> >>>Many ports do not correctly use PTHREAD_{CFLAGS,LIBS}, but that's no
> >>>reason to add another incorrect one.
> >>>
> >>>Kris
> >>
> >>Where is this correctly outlined?  What I'm finding is wildly varying.
> >
> >
> >In my email :-)
> >
> >Kris
>=20
> This ?
>=20
> CONFIGURE_ENV=3D  CFLAGS=3D"-I${LOCALBASE}/include ${PTHREAD_CFLAGS}" \
>                 LDFLAGS=3D"-L${LOCALBASE}/lib ${PTHREAD_LIBS}"

That might be an appropriate solution, if everything compiled by the
port is threaded.  Of course, if there's a non-threaded application in
there as well (or there's a threaded application in the port that
doesn't respect CFLAGS or LDFLAGS) then it's wrong.

Kris

--bg08WKrSYDhXBjb5
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAPtPjWry0BWjoQKURAtjDAKCI0aPkHsmy/EBjFqP0lMKjV5UYggCbBhJR
5P7DzMiekF1MP4TYVCC/v1w=
=kgFI
-----END PGP SIGNATURE-----

--bg08WKrSYDhXBjb5--