From owner-freebsd-ports@FreeBSD.ORG Thu Mar 24 12:02:04 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 254941065670; Thu, 24 Mar 2011 12:02:04 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id D1ED38FC0A; Thu, 24 Mar 2011 12:02:03 +0000 (UTC) Received: by iwn33 with SMTP id 33so11554515iwn.13 for ; Thu, 24 Mar 2011 05:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:from :date:x-google-sender-auth:message-id:subject:to:cc:content-type; bh=1chDa0pAfWD/cjTGE/m5PK31c4FU5/4uwLieYgCWtww=; b=XdsnaesZfaYNowoJ1ZnO1P2gu91pv0z68Ud4UvswTOPZYqYNRR1aDB05ta0lfA43Ki 950VuqEkYJjsCS8y5rXf3DQSqv4qzfUtQJVig9HO0dWqtB+8Bvv4yN4hD77m1v6iirTX GAhKaRNW8Cz1XNfuUq9l83MQb/IQuEAOlpcK8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; b=b9sewVy2Yi4ghKVij7+XIMcolCGUMzox3w+0eJdlF0iyWt47U4rvGQ51GEAr1QFrcO p0lLIKr7SiH/mXgTCV2X1S54kpQKmWDKqs1CDd1g/BTitjG/M6/UxbLHnMs61hWQAtTn qQXw24zhXGW50P6lqHgkWNLq9Z4KYPd7FSmos= Received: by 10.231.121.1 with SMTP id f1mr8079706ibr.35.1300968123158; Thu, 24 Mar 2011 05:02:03 -0700 (PDT) MIME-Version: 1.0 Sender: baptiste.daroussin@gmail.com Received: by 10.231.182.76 with HTTP; Thu, 24 Mar 2011 05:01:43 -0700 (PDT) In-Reply-To: <4D8AE328.3020906@freebsd.org> References: <4D8AE328.3020906@freebsd.org> From: Baptiste Daroussin Date: Thu, 24 Mar 2011 13:01:43 +0100 X-Google-Sender-Auth: S-T3aLozEE1h8q6oZkcqcDf9GiY Message-ID: To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-ports@freebsd.org Subject: Re: libreoffice and gcc44+ X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2011 12:02:04 -0000 2011/3/24 Andriy Gapon > > Baptiste, > > I found it necessary to use the attached patch for libreoffice compilation > to > succeed with gcc45. (patch name doesn't conform to the ports standards). > Without the patch my compilation failed because FILE declaration was not > found. > > I am CC-ing ports@ as this is an example of a classical base gcc vs gcc44+ > problem. The reasons for this issue are described here: > http://gcc.gnu.org/gcc-4.3/porting_to.html > See "Header dependency cleanup". > > I am surprised that this kind of problem has sneaked into the release code > of > libreoffice. It could mean two things: (a) they use older gcc themselves; > (b) > FILE/stdio.h inclusion was brought in by some other inclusion likely in > Linux > system header files. > In any case I think that the upstream developers should have used cstdio > header > inclusion and std::FILE if they really need that. > Are you a regular on their development channels? Maybe you could forward > the > report to them? > > Thanks! > -- > Andriy Gapon > I'll forward them your report. Thanks, Bapt