From owner-freebsd-bugs@freebsd.org Thu Jun 16 12:51:58 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1453A475A3 for ; Thu, 16 Jun 2016 12:51:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B05D512D7 for ; Thu, 16 Jun 2016 12:51:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u5GCpwo2047295 for ; Thu, 16 Jun 2016 12:51:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 210319] sys/cpuset.h should not (unconditionally) include sys/queue.h Date: Thu, 16 Jun 2016 12:51:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: knu@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2016 12:51:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210319 Bug ID: 210319 Summary: sys/cpuset.h should not (unconditionally) include sys/queue.h Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: knu@FreeBSD.org Created attachment 171481 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D171481&action= =3Dedit A patch for sys/sys/cpuset.h sys/cpuset.h is included by pthread_np.h, which is included by user applications. sys/queue.h defines a lot of macros that should only be exposed to kernel sources, so the #include directive should be guarded with #ifdef _KERNEL, or just removed if all users are naturally expected to include sys/queue.h. Ruby fails to build on 11-CURRENT due to a macro name clash of LIST_HEAD() between FreeBSD's sys/queue.h and CCAN's list module. http://beefy4.nyi.freebsd.org/data/head-amd64-default/p414752_s299210/logs/= ruby23-2.3.1,1.log The #include directive was added in r299122, but I suspect the line was irrelevant to the rest of the commit. --=20 You are receiving this mail because: You are the assignee for the bug.=