From owner-dev-commits-src-all@freebsd.org Fri Feb 26 17:30:49 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7AD8F567D61; Fri, 26 Feb 2021 17:30:49 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnGs455mpz4bfC; Fri, 26 Feb 2021 17:30:48 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 11QHUhfi031157; Fri, 26 Feb 2021 09:30:43 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 11QHUh8n031156; Fri, 26 Feb 2021 09:30:43 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202102261730.11QHUh8n031156@gndrsh.dnsmgr.net> Subject: Re: git: 2a50a9de8340 - main - terminfo: add terminfo database In-Reply-To: <202102261420.11QEKJoX006569@slippy.cwsent.com> To: Cy Schubert Date: Fri, 26 Feb 2021 09:30:43 -0800 (PST) CC: Baptiste Daroussin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4DnGs455mpz4bfC X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd@gndrsh.dnsmgr.net X-Spamd-Result: default: False [1.44 / 15.00]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.84)[0.844]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[69.59.192.140:from:127.0.2.255]; NEURAL_SPAM_MEDIUM(0.69)[0.694]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[69.59.192.140:from]; RCVD_TLS_LAST(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 17:30:49 -0000 > In message <202102251327.11PDR4eC083842@gitrepo.freebsd.org>, Baptiste > Daroussi > n writes: > > The branch main has been updated by bapt: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2a50a9de8340f08bd876e9e5993332ae > > 14376f80 > > > > commit 2a50a9de8340f08bd876e9e5993332ae14376f80 > > Author: Baptiste Daroussin > > AuthorDate: 2021-02-23 16:17:32 +0000 > > Commit: Baptiste Daroussin > > CommitDate: 2021-02-25 13:25:32 +0000 > > > > terminfo: add terminfo database > > > > Tested by: manu, jbeich > > --- > > share/Makefile | 1 + > > share/terminfo/Makefile | 34 ++++++++++++++++++++++++++++++++++ > > 2 files changed, 35 insertions(+) > > > > diff --git a/share/Makefile b/share/Makefile > > index c4e12b05f7db..d6854b230ae5 100644 > > --- a/share/Makefile > > +++ b/share/Makefile > > @@ -26,6 +26,7 @@ SUBDIR= ${_colldef} \ > > ${_syscons} \ > > tabset \ > > termcap \ > > + terminfo \ > > ${_timedef} \ > > ${_vt} \ > > ${_zoneinfo} > > diff --git a/share/terminfo/Makefile b/share/terminfo/Makefile > > new file mode 100644 > > index 000000000000..7bb11f3fdf24 > > --- /dev/null > > +++ b/share/terminfo/Makefile > > @@ -0,0 +1,34 @@ > > +PACKAGE= runtime > > + > > +.PATH: ${SRCTOP}/contrib/ncurses/misc > > +TINFOBUILDDIR= ${.OBJDIR}/builddir > > +CLEANDIRS+= builddir > > + > > +.include > > + > > +.if !defined(_SKIP_BUILD) > > +all: terminfo > > +.endif > > +META_TARGETS+= terminfo install-terminfo > > + > > +terminfo: terminfo.src > > + mkdir -p ${TINFOBUILDDIR} > > + ${TIC_CMD} -x -o ${TINFOBUILDDIR} ${.ALLSRC} > > + > > +.if make(*install*) > > +TINFOS!= cd ${TINFOBUILDDIR} && find * -type f | LC_ALL=C sort > > +TINFOSDIRS= ${TINFOS:C/(.).*/\1/g:O:u} > > +.endif > > + > > +beforeinstall: install-terminfo > > +install-terminfo: > > + mkdir -p ${DESTDIR}/usr/share/terminfo > > + cd ${DESTDIR}/usr/share/terminfo; mkdir -p ${TINFOSDIRS} > > +.for f in ${TINFOS} > > + ${INSTALL} ${TAG_ARGS} \ > > + -o ${BINOWN} -g ${BINGRP} -m ${NOBINMODE} \ > > + ${TINFOBUILDDIR}/${f} ${DESTDIR}/usr/share/terminfo/${f} > > +.endfor > > + > > +.include > > + > > > > I think this had some unintended consequences, a POLA violation that should > be documented. Our termcap didn't support alternate screen buffers while > terminfo does. Termcap did through t_te and t_ti but we didn't use them. > Terminfo as delivered from the ncurses factory does supply rmcup and smcup; > our fullscreen apps such as nvi and top see them and use the alternate > screen buffer. > > The use of the alternate screen buffer is one of the things I hate about > Linux. After running vi or top I expect the output to remain on the screen > so I can use some bit of information in my next command. We now have this > behaviour too. Oh, I so hate that mis-feature of Linux, please please tell me there is a simple knob to turn this off? I believe LESS also does this kind of stuff, or atleast "man" on linux does, and that pees me off to no end when I quit the man page and what I wanted is no longer on the screen. > The alternate screen buffer was added to xterm an ice age ago. Most modern > terminal emulators support it. As much as I feel the need to yank out rmcup > an smcup from our terminfo database, we are using a feature, as distasteful > as it may feel. This change probably needs a relnotes=yes and an UPDATING > entry advising users that they can either change $TERM to xterm1, vt100, or > some other terminal definition that doesn't support rmcup and smcup, or > learn to like it. > > OTOH, maybe this is something we as a community don't really want and we > remove the rmcup and smcup definitions from our terminfo database. > Personally, I believe this is progress -- progress I'm not particularly > enamoured with but progress nonetheless. But I think we need to discuss, > come to some sort of decision and document it. > > Thoughts? > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > The need of the many outweighs the greed of the few. > > > -- Rod Grimes rgrimes@freebsd.org