From owner-freebsd-ports  Sat Oct 19 16:40: 4 2002
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3695E37B404
	for <freebsd-ports@hub.freebsd.org>; Sat, 19 Oct 2002 16:40:03 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B481243E75
	for <freebsd-ports@hub.freebsd.org>; Sat, 19 Oct 2002 16:40:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9JNe2x3084352
	for <freebsd-ports@freefall.freebsd.org>; Sat, 19 Oct 2002 16:40:02 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9JNe2pU084351;
	Sat, 19 Oct 2002 16:40:02 -0700 (PDT)
Date: Sat, 19 Oct 2002 16:40:02 -0700 (PDT)
Message-Id: <200210192340.g9JNe2pU084351@freefall.freebsd.org>
To: freebsd-ports@FreeBSD.org
Cc: 
From: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
Subject: Re: ports/44287: Fix build of mail/xmail
Reply-To: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

The following reply was made to PR ports/44287; it has been noted by GNATS.

From: "Steven G. Kargl" <kargl@troutmask.apl.washington.edu>
To: Kris Kennaway <kris@obsecurity.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: ports/44287: Fix build of mail/xmail
Date: Sat, 19 Oct 2002 16:30:31 -0700 (PDT)

 Kris Kennaway said:
 > On Sat, Oct 19, 2002 at 03:32:25PM -0700, Steven G. Kargl wrote:
 > 
 > >  extern char	noshare *sys_errlist[];
 > >  #else
 > >  extern int	errno;
 > > -extern int	sys_nerr;
 > > -extern char	*sys_errlist[];
 > >  #endif
 > 
 > You should avoid defining errno as well - it doesn't currently cause
 > an error, but it's wrong.
 > 
 > Instead of patching these out, you should conditionally compile them
 > in the !defined(__FreeBSD__) case.  This will make the patch more
 > acceptable to be taken back by the upstream author.
 > 
 
 Kris,
 
 Okay, I'll start removing "extern int errno" when I see it.
 As to the use of !defined(__FreeBSD__), I started with the
 current patch and simply fix it.  Should I discard old 
 patches in favor of !defined(__FreeBSD__)?
 
 -- 
 Steve
 http://troutmask.apl.washington.edu/~kargl/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message