Date: Tue, 24 Mar 2015 20:50:32 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Julian Elischer <julian@freebsd.org>, ports@freebsd.org Cc: mva@freebsd.org Subject: Re: patch to bsd.ports.mk to support out-of-tree patches. Message-ID: <55121468.2040308@FreeBSD.org> In-Reply-To: <20150324113240.Horde._MOpnfwGcxQa7v8pi_ozUQ2@webmail.df.eu> References: <5510F71B.7030900@freebsd.org> <20150324113240.Horde._MOpnfwGcxQa7v8pi_ozUQ2@webmail.df.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--fjtKXxOqNKJRKJviPblFJxd2cbWbU1m7n
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 3/24/2015 5:32 AM, Marcus von Appen wrote:
> Julian Elischer <julian@freebsd.org>:
>=20
> [...]
>> esac | ${PATCH} ${PATCH_DIST_ARGS} `patch_dist_strip $$i` ; \=
>> done )
>> .endif
>> +.if defined(EXTRA_PATCH_TREE)
> [...]
>> +.endif
>> .if defined(EXTRA_PATCHES)
>> @set -e ; \
>> for i in ${EXTRA_PATCHES}; do \
>>
>>
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> Nice. I'd however change the patch behaviour to the following:
>=20
> - patch-* from FreeBSD
> - EXTRA_PATCHES from FreeBSD
> - local patches
>=20
> Your patch looks like it appleis the out-of-tree patches prior
> to any EXTRA_PATCHES defined by the port itself. This should not be
> the case, in my opinion. Locally managed patches should always come
> last to ensure that all FreeBSD/maintainer-specific bits have been
> applied and the local changes are just added on top of those.
>=20
> Cheers
> Marcus
>=20
Agreed. The local patches are intended to avoid touching the port. If
they are not last then you may have to go tweaking some of the other
ports patches to fix your own.
--=20
Regards,
Bryan Drewery
--fjtKXxOqNKJRKJviPblFJxd2cbWbU1m7n
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJVEhRoAAoJEDXXcbtuRpfPBEgIAK8umMiyFNDvkYILtEP9jjLW
uB7nOyI1ehBXnjaI22nEBKPLwWsWNtMZ4AXXPZGU4/nBBcRLRCoaZn7rzWUROBc6
EoqV7MNz17o54sIr+Rp/MHc3uB2X1yT3G89LYgU4dcSper/O0I8xvbTHWrQCizVb
bkJ8DWB7mPfx5aLz1jKHEJZokffmH3TgLKjRh+aFdJaJCqlxVUBDv5z8nlxS1EqO
wLei6sJ4H1eH5YTce9RKaUI+2WXT8WUrLNI4IWFDuMl6bYgnZIxmlIEtGn+kTF0p
3zZIQb/o+zObkIJ+2cz/U/zkQPF6EutTt1/ok05kVL373daSxYBGb7OHfx40FNQ=
=YaEj
-----END PGP SIGNATURE-----
--fjtKXxOqNKJRKJviPblFJxd2cbWbU1m7n--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55121468.2040308>