From owner-freebsd-current@FreeBSD.ORG Fri May 29 16:51:06 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 95D69A9; Fri, 29 May 2015 16:51:06 +0000 (UTC) (envelope-from jenkins-admin@freebsd.org) Received: from jenkins-9.freebsd.org (jenkins-9.freebsd.org [8.8.178.209]) by mx1.freebsd.org (Postfix) with ESMTP id 8495B11A0; Fri, 29 May 2015 16:51:06 +0000 (UTC) (envelope-from jenkins-admin@freebsd.org) Received: from jenkins-9.freebsd.org (localhost [127.0.0.1]) by jenkins-9.freebsd.org (Postfix) with ESMTP id A81946BD; Fri, 29 May 2015 16:51:05 +0000 (UTC) Date: Fri, 29 May 2015 16:51:03 +0000 (GMT) From: jenkins-admin@freebsd.org To: jenkins-admin@FreeBSD.org, freebsd-current@freebsd.org Message-ID: <209327650.15.1432918264037.JavaMail.jenkins@jenkins-9.freebsd.org> In-Reply-To: <1055108530.13.1432892323631.JavaMail.jenkins@jenkins-9.freebsd.org> References: <1055108530.13.1432892323631.JavaMail.jenkins@jenkins-9.freebsd.org> Subject: FreeBSD_HEAD-tests - Build #1068 - Still Unstable MIME-Version: 1.0 X-Jenkins-Job: FreeBSD_HEAD-tests X-Jenkins-Result: UNSTABLE Precedence: bulk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 16:51:06 -0000 FreeBSD_HEAD-tests - Build #1068 - Still Unstable: Check console output at https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1068/ to view the results. From owner-freebsd-current@FreeBSD.ORG Fri May 29 23:47:08 2015 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4BD2C96F; Fri, 29 May 2015 23:47:08 +0000 (UTC) (envelope-from jenkins-admin@freebsd.org) Received: from jenkins-9.freebsd.org (jenkins-9.freebsd.org [8.8.178.209]) by mx1.freebsd.org (Postfix) with ESMTP id 39FB31ADB; Fri, 29 May 2015 23:47:08 +0000 (UTC) (envelope-from jenkins-admin@freebsd.org) Received: from jenkins-9.freebsd.org (localhost [127.0.0.1]) by jenkins-9.freebsd.org (Postfix) with ESMTP id B9332759; Fri, 29 May 2015 23:47:05 +0000 (UTC) Date: Fri, 29 May 2015 23:47:04 +0000 (GMT) From: jenkins-admin@freebsd.org To: jenkins-admin@FreeBSD.org, freebsd-current@freebsd.org Message-ID: <1021331953.18.1432943225015.JavaMail.jenkins@jenkins-9.freebsd.org> In-Reply-To: <209327650.15.1432918264037.JavaMail.jenkins@jenkins-9.freebsd.org> References: <209327650.15.1432918264037.JavaMail.jenkins@jenkins-9.freebsd.org> Subject: FreeBSD_HEAD-tests - Build #1069 - Still Unstable MIME-Version: 1.0 X-Jenkins-Job: FreeBSD_HEAD-tests X-Jenkins-Result: UNSTABLE Precedence: bulk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 23:47:08 -0000 FreeBSD_HEAD-tests - Build #1069 - Still Unstable: Check console output at https://jenkins.freebsd.org/job/FreeBSD_HEAD-tests/1069/ to view the results. From owner-freebsd-current@FreeBSD.ORG Sat May 30 08:17:19 2015 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC7549D2 for ; Sat, 30 May 2015 08:17:19 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 0038A1DAD for ; Sat, 30 May 2015 08:17:18 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id LAA07599; Sat, 30 May 2015 11:17:09 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Yybx7-0002RV-0b; Sat, 30 May 2015 11:17:09 +0300 Message-ID: <556971B2.8060002@FreeBSD.org> Date: Sat, 30 May 2015 11:15:46 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Konstantin Belousov CC: FreeBSD Current Subject: Re: per file descriptor device driver data ? References: <20150529123753.GF2499@kib.kiev.ua> In-Reply-To: <20150529123753.GF2499@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2015 08:17:19 -0000 On 29/05/2015 15:37, Konstantin Belousov wrote: > On Fri, May 29, 2015 at 02:24:14PM +0200, Luigi Rizzo wrote: >> Hi, >> in the kernel module for netmap we need to store some >> private data associated to each open netmap file descriptor. >> >> Our current design uses devfs_set_cdevpriv() during the open() >> handler, but for some reason a subsequent devfs_get_cdevpriv(p) >> returns *p = NULL in additional threads created by the process >> that did the open(). >> >> The manpage devfs_set_cdevpriv() does not mention threads, >> and so i am a bit puzzled why the cdevpriv is only good >> for the original thread. > Probably, due to a bug, and the bug is more likely in the consumer code, > than in cdevpriv. The cdevpriv requires the current file context, i.e. > you should be in the context of the syscall which is operating on the > file, to get the file related private data. > > If you believe that the bug is in cdevpriv interface, please provide the > minimal example to demonstrate the issue. I know of one case where ZFS driver has to play tricks with devfs_get_cdevpriv(), please see zfs_onexit_fd_hold(). >> >> In the linux version 'struct file' has a "private_data" field >> that we use for that purpose, and remains valid on all threads. >> i wonder if there is something similar we can use in FreeBSD. -- Andriy Gapon