From owner-freebsd-ports@freebsd.org  Fri Oct  9 12:54:11 2015
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A15D39D17B9
 for <freebsd-ports@mailman.ysv.freebsd.org>;
 Fri,  9 Oct 2015 12:54:11 +0000 (UTC)
 (envelope-from mailinglists@toco-domains.de)
Received: from toco-domains.de (mail.toco-domains.de
 [IPv6:2a01:4f8:150:50a5::6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6BFB1B73
 for <freebsd-ports@freebsd.org>; Fri,  9 Oct 2015 12:54:11 +0000 (UTC)
 (envelope-from mailinglists@toco-domains.de)
Received: from [0.0.0.0] (mail.toco-domains.de [IPv6:2a01:4f8:150:50a5::6])
 by toco-domains.de (Postfix) with ESMTPA id 71E681B22835;
 Fri,  9 Oct 2015 14:54:06 +0200 (CEST)
Subject: Re: Commiter needed for PR 200652
To: =?UTF-8?Q?Martin_Waschb=c3=bcsch?= <martin@waschbuesch.de>,
 FreeBSD ports <freebsd-ports@freebsd.org>
References: <BAAEFA33-7119-4A3F-AE8F-B7A73A20F547@waschbuesch.de>
From: Torsten Zuehlsdorff <mailinglists@toco-domains.de>
Message-ID: <5617B8E3.1070801@toco-domains.de>
Date: Fri, 9 Oct 2015 14:53:55 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <BAAEFA33-7119-4A3F-AE8F-B7A73A20F547@waschbuesch.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Oct 2015 12:54:11 -0000

Hello,

> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200652
>
> It's glue to use the existing ports
>
> p5-CGI-ExtDirect
> p5-RPC-ExtDirect
>
> with plack environment.
>
> It's been open since June, so perhaps someone could take pity and commit it? :-D

I'm not a committer, but i take a short look at it. I think you should 
make a little more QA.

First i see there is a PORTEPOCH. Since this is a new port, this line 
should be there.

Also you comment out an build dependency. Better to remove it completely.

It is also a good idea to use "portlint -AC" against the new port and 
add some poudriere logs, which proves everything works fine.

If you need any help with this, feel free to contact me.

Greetings,
Torsten