From owner-svn-src-all@freebsd.org Wed May 18 16:54:14 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D698B41E67 for ; Wed, 18 May 2016 16:54:14 +0000 (UTC) (envelope-from scott4long@yahoo.com) Received: from nm16-vm5.bullet.mail.gq1.yahoo.com (nm16-vm5.bullet.mail.gq1.yahoo.com [98.137.177.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 72A5A183F for ; Wed, 18 May 2016 16:54:14 +0000 (UTC) (envelope-from scott4long@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1463589631; bh=+oo3loTaTst5qI4KckX409Wgfo2u4y15ulqFaZiy6n8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject; b=owiCy59/zUPk0H4xJ9qd0XUSMVJxnu7gpVDmb/jGSdrdgicDCm3vfc4PjVPgZu4Truphd2Z0iAwFx2oOM6I7fQ3rCtSjn8LFUEHmvBIplta0htM3KkRklsVj7+8+r0Kp99bMyCE6lfH/W80fZqYGg4FGX06U6XAbBYeaFpjlWzGRKesI+K3mvlpeP51he5DGcHCwblIalBtfa0TcVxjs3BRCq4wxp0NJ0a05ybQFKFMQd1JQXzkoQ7eqBfezDIiXzrirtf5JV9yDWEXTWEKdOUVYTOiORCD6VG9ga+l6x0mjF5BDoftYaI5T/My8QQHgJQFTz3wYrTbWOxdzikP/ww== Received: from [98.137.12.57] by nm16.bullet.mail.gq1.yahoo.com with NNFMP; 18 May 2016 16:40:31 -0000 Received: from [98.136.164.71] by tm2.bullet.mail.gq1.yahoo.com with NNFMP; 18 May 2016 16:40:31 -0000 Received: from [127.0.0.1] by smtp233.mail.gq1.yahoo.com with NNFMP; 18 May 2016 16:40:31 -0000 X-Yahoo-Newman-Id: 326418.57415.bm@smtp233.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 6T8l3uEVM1k1P_F5ciJej.D2bPDEb6WRdpPAF_yEOJu5dpA tB4LYBFhePMcCq0hgd8uw._V3Jp9KomJzB5bI1mg8rLYl3WPZ9UpUfnNyH.l .OuXLfsItjNCC3f3geV1e2gQaVK_UwOQvElPo8RliQ7SKVUJtcx.bLoMUXoy XcKwicA11kehuMa13BP7tB_Tpy_f91NyWf0hXPSeGkbjRhqa2ElLx4GGhzuw z2KmlqXK40m7FzTVSDJmjhbHaqNUoL7YDgWDinI685ysRbi7goHTLhECvt2a UMQd0v_JIPld4Hw_0ZmFARqpdCld0zrK5.rwbiH04aaJnlDibNu2G6Zk0G_6 b3XDUrBIFdv4GPUC2.hGwX1ndOyK1KDqKPo_jNvs7PxXGDkOOtYZUPOBCtOq DcYhlvqMP5ShRjI.74JgX_MU0oaYI1FUR5SWl3rYL6uDpjQcEj8mQ1heZA2w v2lvoJlSKieNVSneDvjkOQspyYoJa3RQSAo4zarj3igj0dKCz50KTs7HxIml Qt.QFWFNFRyj5KD3HZNAucQGvDhXaAiqmJkGL.fw- X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r300154 - head/sys/net From: Scott Long In-Reply-To: Date: Wed, 18 May 2016 10:40:27 -0600 Cc: Justin Hibbits , Scott Long , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <7EC6D845-E9EE-4D9E-988B-D433526BAAB1@yahoo.com> References: <201605181545.u4IFjCKD030751@repo.freebsd.org> <20160518105033.1eae7432@zhabar.knownspace> To: Warner Losh X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 May 2016 16:54:14 -0000 What should I use instead? Scott > On May 18, 2016, at 10:03 AM, Warner Losh wrote: >=20 > Ditto with mips. >=20 > On Wed, May 18, 2016 at 9:50 AM, Justin Hibbits = wrote: > On Wed, 18 May 2016 15:45:12 +0000 (UTC) > Scott Long wrote: >=20 > > Author: scottl > > Date: Wed May 18 15:45:12 2016 > > New Revision: 300154 > > URL: https://svnweb.freebsd.org/changeset/base/300154 > > > > Log: > > Activate the NO_64BIT_ATOMICS code for mips and powerpc > > > > Modified: > > head/sys/net/mp_ring.c > > > > Modified: head/sys/net/mp_ring.c > > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > > --- head/sys/net/mp_ring.c Wed May 18 15:44:45 2016 > > (r300153) +++ head/sys/net/mp_ring.c Wed May 18 15:45:12 > > 2016 (r300154) @@ -37,15 +37,17 @@ __FBSDID("$FreeBSD$"); > > #include > > #include > > > > - > > - > > -#include > > +#if defined(__powerpc__) || defined(__mips__) > > +#define NO_64BIT_ATOMICS > > +#endif > > > > #if defined(__i386__) > > #define atomic_cmpset_acq_64 atomic_cmpset_64 > > #define atomic_cmpset_rel_64 atomic_cmpset_64 > > #endif > > > > +#include > > + > > union ring_state { > > struct { > > uint16_t pidx_head; > > >=20 > powerpc64 defines both __powerpc__ and __powerpc64__, so you're = killing > atomics on powerpc64 with this. >=20 > - Justin >=20 >=20