Date: Sat, 10 Oct 2020 21:45:58 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Shawn Webb <shawn.webb@hardenedbsd.org> Cc: FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: OpenJDK ports and 13-CURRENT Message-ID: <8DD818E8-2569-4E2F-8BAD-143F8AE7FAE5@FreeBSD.org> In-Reply-To: <20201010192334.auepsizn3w57soes@mutt-hbsd> References: <20201010190337.qtvivmpmzw4gtk3h@mutt-hbsd> <4ADAFC01-2148-48BE-AAE8-5E6A269C14CE@FreeBSD.org> <20201010192334.auepsizn3w57soes@mutt-hbsd>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_1BA4978F-6292-486D-BA4A-0E936209E42B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 10 Oct 2020, at 21:23, Shawn Webb <shawn.webb@hardenedbsd.org> wrote: >=20 > On Sat, Oct 10, 2020 at 09:18:08PM +0200, Dimitry Andric wrote: >> On 10 Oct 2020, at 21:03, Shawn Webb <shawn.webb@hardenedbsd.org> = wrote: >>> It appears the latest import of llvm 11.0.0 breaks the OpenJDK 12 = and >>> above ports. Is anyone tracking this breakage? >>=20 >> Define "break". :) I can't find any PR, so I don't think so. The = latest >> builds on the ports cluster seem to have succeeded, but even though = the >> ports builder says "head-amd64-default-job", it appears to compile = with >> clang 8.0.1, for some reason. Might be incorrect, or on purpose, I = don't >> know. >=20 > Log of the HardenedBSD 13-CURRENT/amd64 package > = build:http://ci-03.md.hardenedbsd.org/data/hardenedbsd-13_amd64-local/2020= -10-09_14h46m02s/logs/errors/openjdk12-12.0.2+10.4_1.log >=20 > HardenedBSD has switched to a full llvm compiler toolchain. I wonder > if that's the culprit? Using llvm-ar, llvm-nm, et al. >=20 > Googling for the duplicate symbol error brought me this result: > = https://www.mail-archive.com/freebsd-pkg-fallout@freebsd.org/msg1544005.ht= ml Ah, that is -fno-common fallout, strange that there is no build breakage reported in the FreeBSD ports build cluster? =46rom gcc 10 and clang 11 onwards, -fno-common is the default (this is really a historical mistake, -fcommon should never have been default). It can result in link errors, if duplicate symbols exist in object files. There is a suprising amount of software that makes this very basic mistake! The quick way to work around these errors is to set -fcommon in CFLAGS, which will basically fudge around the actual issue. The better way is to get rid of the duplicated symbols. This is usually easy, except that Java ports tend to take ages to build. :) I'll submit a patch when my machine's finished crunching through it. -Dimitry --Apple-Mail=_1BA4978F-6292-486D-BA4A-0E936209E42B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCX4IPdgAKCRCwXqMKLiCW o7PxAKDrcRqRYqPyhDPJXs2W+gmm3quKlQCcDLeok9a1ow8sbH8q8AD2C9PPHHQ= =qiRI -----END PGP SIGNATURE----- --Apple-Mail=_1BA4978F-6292-486D-BA4A-0E936209E42B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8DD818E8-2569-4E2F-8BAD-143F8AE7FAE5>