From owner-cvs-all@FreeBSD.ORG Sat Dec 25 01:08:56 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1398A16A4CE; Sat, 25 Dec 2004 01:08:56 +0000 (GMT) Received: from mailout01.sul.t-online.com (mailout01.sul.t-online.com [194.25.134.80]) by mx1.FreeBSD.org (Postfix) with ESMTP id 85BC243D1F; Sat, 25 Dec 2004 01:08:55 +0000 (GMT) (envelope-from Alexander@Leidinger.net) Received: from fwd10.aul.t-online.de by mailout01.sul.t-online.com with smtp id 1Ci0QQ-00059S-00; Sat, 25 Dec 2004 02:08:54 +0100 Received: from Andro-Beta.Leidinger.net (X7RSE6ZBre0Y9TlQrCepxnDngtzcDbr-WSkgnzfM4cjFs0vP6QFRsQ@[217.229.221.6]) by fmrl10.sul.t-online.com with esmtp id 1Ci0QG-1KTIQq0; Sat, 25 Dec 2004 02:08:44 +0100 Received: from Magellan.Leidinger.net (Magellan.Leidinger.net [192.168.1.1]) iBP18ZaY067620; Sat, 25 Dec 2004 02:08:35 +0100 (CET) (envelope-from Alexander@Leidinger.net) Date: Sat, 25 Dec 2004 02:08:53 +0100 From: Alexander Leidinger To: Trevor Johnson Message-ID: <20041225020853.008496a1@Magellan.Leidinger.net> In-Reply-To: <20041224165045.K40731@blues.jpj.net> References: <200412220036.iBM0aWNf091183@repoman.freebsd.org> <20041224181509.431b3df7@Magellan.Leidinger.net> <20041224165045.K40731@blues.jpj.net> X-Mailer: Sylpheed-Claws 0.9.13 (GTK+ 1.2.10; i386-portbld-freebsd6.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ID: X7RSE6ZBre0Y9TlQrCepxnDngtzcDbr-WSkgnzfM4cjFs0vP6QFRsQ@t-dialin.net X-TOI-MSGID: 60804269-3ac8-4792-a784-edeaa20eebc5 cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/x11/linux-XFree86-libs Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Dec 2004 01:08:56 -0000 On Fri, 24 Dec 2004 17:35:54 -0500 (EST) Trevor Johnson wrote: > > > Modified files: > > > x11/linux-XFree86-libs Makefile > > > Log: > > > This works with linux_base-rh-9 and linux_base-suse-9.1 as well as > > > linux_base-8. > > > > I'm not sure removing the dependency on any linux_base is the right > > thing to do. Additionally I think we shouldn't support more than one > > linux_base. It's fine if it works with more than one linux_base, but we > > can't guarantee it. > > I made sure that it works with those three. I designed them from the > get-go to work with it. If they actually do not, kindly report the > bug. I failed to explain it the right way... we can't guarantee that every linux port is able to run with every linux_base. > Traditionally we've had multiple linux_base ports. I have no problem with > that tradition--it's not in our power to unify all the Linux > distributions, nor for that matter all the X11 distributions! That's not the point. We just don't have the resources to support all linux ports with every linux_base. > > My suggestion is: let it depend upon the default linux_base by default > > (my patchset takes care of this). After 4.11 is out the door, let's > > update the default linux_base to a recent one, remove all > > obsolete/outdated/forbidden linux_base ports, get everything into good > > shape and think about how to allow non-default linux_base ports to work > > with everything (e.g. a patch for bsd.port.mk which modifies the > > USE_LINUX code to use an already installed linux_base (with a warning > > that we don't guarantee anything) or to install a predefined one, like > > we did with the X_WINDOW_SYSTEM part of bsd.port.mk). > > The patch you sent me would have added a dependency on this port to the > Linux ports which need X11 (presently, I ask users to install this port > manually). I don't see how my commit conflicts with the patch you sent > me. Does this commit create an actual problem? It doesn't create a conflict, but as Kris already noted: it breaks the build on the ports build cluster. You've removed the dependency to a linux_base, therefore rpm can't find a file it needs. As you can see above, I don't object on what you intended to do, but how you did it (the port has to depend upon a linux_base port, and I already outlined above how this can be achieved). Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7