From owner-cvs-all@FreeBSD.ORG  Fri Mar 18 20:25:12 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A909716A4CE; Fri, 18 Mar 2005 20:25:12 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8BC9943D53; Fri, 18 Mar 2005 20:25:11 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id j2IKPA3K018716;
	Fri, 18 Mar 2005 21:25:10 +0100 (CET)
	(envelope-from phk@critter.freebsd.dk)
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 18 Mar 2005 19:57:53 +0100."
             <20050318185753.GS591@darkness.comp.waw.pl> 
Date: Fri, 18 Mar 2005 21:25:10 +0100
Message-ID: <18715.1111177510@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/geom geom_gpt.c 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Mar 2005 20:25:12 -0000

In message <20050318185753.GS591@darkness.comp.waw.pl>, Pawel Jakub Dawidek wri
tes:

>+> >Does any of these changes fix the panic when attempting to mount an
>+> >audio CD-ROM?
>+>=20
>+> Uhh, dunno, what panics ?  Do you know which GEOM class ?
>
>panic: wrong offset 65536 for sectorsize 2352

>ffs_mountfs(c154c6a8,c107d000,c1078450,c113a0c0,0) at ffs_mountfs+0x23e
>ffs_mount(c107d000,c1078450,0,0,c154b354) at ffs_mount+0x925

FFS and other filesystems needs to find out that they cannot work with
the sectorsize proposed.

We can either do that by turning the panic into an EIO or by explicitly
checking in the filesystems.

I guess EIO makes most sense, and since I havn't seen this panic find
anything important for a long time I guess that's the way.

Anyone want to do it ?

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.