From nobody Fri Apr 17 20:28:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fy6003yF0z6YVsT for ; Fri, 17 Apr 2026 20:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fy6002FfYz3CHF for ; Fri, 17 Apr 2026 20:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776457696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WnXw/AF/ob5QcmhqmlJpvo9mW0IP0J23qBQVvJuY/Ic=; b=vXY7f95lHeuixhqnkzoHNb63cOxgQoV175cEMPk2oLC6q7qwylPiTWuwVgx3ecWsk1+fSZ +UQOjyoARangVKAl4AvO2UtzkTaF65Hhz/o8RH2ymDfJk18wQjwmTYVS854VSzuUPjRg5X 7r4qCTdSVfHb7xnSXsB9M4ECTeX5E3RA0RwO/1drH7HG+JxujT7bdNWJHp4XTpURDPaMWn fCXr/VPm2ANtqvTS81J32mTaNVBOvmQ/o8u5vY6aUo8Iu/oJ37xjTEX9AQVqIy80QezkxJ w0TXBbq1pBILQ1p88MdOMpOV+4x+XLzd93Ec1nKAHxwEWAc3ymQqQaOKUHufIw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776457696; a=rsa-sha256; cv=none; b=mPAmdDd3ZXGmtUnSW6lG1DMfwC2qJuO7iuubdnw2R1DtNoS6NeRFSIyywY6AROGPGREYh9 LZx5oX4hJuBaQDHTUI9X/2D6prNP858g+bo96sGwKXYgdv19d+HcPJE0YXYQYqK5G3caym fCiqsLuTqp60o4sAnNk82lBF9y511TuNel9ZLfHjxtImhzkBW/XjDAaGew7Y5kufWUMcwr G5EHsVFLqjGYWDow6o8KhRmvwD531RJWBAKWDPib7ygDC7VKcwKqDoRP4RId9P58Spspb5 wO0YAMKFwt6bkENVExjcgbHU7QLHaJ8LUVMo1dWrcH40iaJ5dAeW5umfkzNfDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776457696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WnXw/AF/ob5QcmhqmlJpvo9mW0IP0J23qBQVvJuY/Ic=; b=oSl6KQh3MXZNBzjqfFxGMony75q8o4+OzbJ98eC4LDces1Rwybu1XCLke+9z/ZPz7LEpcW 1/ijSPFlBUqqgmkga0c7RTZb87rYUCXme1ZalnALE2HMTbpfD9aR1M3tlLE+jeFhQEHCcJ mjGoBVJGXsvzSAJeqdE2DZF3mCVrnD7woU55QiuH2sSAVnhQV6roYO/N3WmRTQY1TF6gqr PVqylM7wWiwlJrTEbWG3Nvr0vcgeOgotHI9jVHTf4CX3THpbacVBYSmH7ex5nV2ZevnPnU cwRGlhH91AVSgj2mcGmtO/6onOUszsg4Yuuoc9fRTsuFZlO8MrbKd3ymC3VJAA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fy6001TT3z17sZ for ; Fri, 17 Apr 2026 20:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 20712 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 17 Apr 2026 20:28:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: bd05b47fbd8b - main - acpi_spmc(4): Small probe improvements/fixes List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bd05b47fbd8b7301983dc4ceaf0498fb8d5ca9f2 Auto-Submitted: auto-generated Date: Fri, 17 Apr 2026 20:28:11 +0000 Message-Id: <69e297db.20712.efdbc17@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=bd05b47fbd8b7301983dc4ceaf0498fb8d5ca9f2 commit bd05b47fbd8b7301983dc4ceaf0498fb8d5ca9f2 Author: Olivier Certner AuthorDate: 2026-04-10 14:15:09 +0000 Commit: Olivier Certner CommitDate: 2026-04-17 20:27:51 +0000 acpi_spmc(4): Small probe improvements/fixes Remove the test on presence of an ACPI handle, this is implied by ACPI_ID_PROBE() succeeding. Set 'sc->dev' early, so that acpi_spmc_check_dsm_set() using device_printf() will print the driver name. Add a missing newline after printing that more DSM functions are implemented then expected. Reviewed by: obiwac Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D56483 --- sys/dev/acpica/acpi_spmc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c index ca7b3bd95ead..5be2ba439de4 100644 --- a/sys/dev/acpica/acpi_spmc.c +++ b/sys/dev/acpica/acpi_spmc.c @@ -200,12 +200,13 @@ acpi_spmc_probe(device_t dev) } handle = acpi_get_handle(dev); - if (handle == NULL) - return (ENXIO); + /* ACPI_ID_PROBE() above cannot succeed without a handle. */ + MPASS(handle != NULL); sc = device_get_softc(dev); + sc->dev = dev; - /* Check which sets of DSM's are supported. */ + /* Check which sets of DSMs are supported. */ sc->dsm_sets = 0; acpi_spmc_check_dsm_set(sc, handle, &intel_dsm_set); @@ -286,7 +287,7 @@ acpi_spmc_check_dsm_set(struct acpi_spmc_softc *sc, ACPI_HANDLE handle, if ((dsms_supported & ~max_dsms) != 0) device_printf(sc->dev, "DSM set %s supports more DSMs than " - "expected (%#" PRIx64 " vs %#" PRIx64 ").", dsm_set->name, + "expected (%#" PRIx64 " vs %#" PRIx64 ").\n", dsm_set->name, dsms_supported, max_dsms); }