From owner-svn-src-all@freebsd.org Wed May 31 17:38:54 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5304B7F55F; Wed, 31 May 2017 17:38:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A3971E9A; Wed, 31 May 2017 17:38:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id h64so2654424pge.3; Wed, 31 May 2017 10:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=k+t8cgpRoYxlHUqOR9dSOhhJ73VtCHcqQvmBalJ2w5E=; b=PnRqv78nYQtVKkcNxaVpZOHF7KqWhPO5mwvyVEVOe1I/5KhV0RTX/MBCqztxjSr3DH Huoz65l7tx9BCwcJPo3/VMPNYGyfsUZjbbB36mk5/mtkkc8MzFuTn3MYTWTRPWowR8hT SRYESZEwXvbPQrpBSl6p5XcclOqz7eAwESG7ECknJ40izkfpHz8JJIBb9dYcDVtmlwac ZExNB8ZATjeylE9Ozngm+Yp8iCv3cUX3eqz6/X0fStbZyezkSzTx62hv5RQJOJxMIkyv 3TGHWWVSEQvT2giApJUxDfPwLT1nlHs2kL9nwctMLbKfjD5K2GsmGQ5GtH82WBXERi6x JtBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=k+t8cgpRoYxlHUqOR9dSOhhJ73VtCHcqQvmBalJ2w5E=; b=iP5IfwykRKZbi25+30hf7fiVHzo4C5Zse1pQRMCtlpQQJ1jmtAI3V5trvF7LtCbhpo QLXr7eBJZ7eBpiOxrXFMcRMHmbpOm/lS43a8yWi9f9+EyTgGuLTn4DGRdruZu2I1nK/i hzIabnD39kKx/ZCHTndSvKE5dxAeiA4wQ6YCSY+KxZ7ryfnqxZ7KvlirFxtPG7LQ8JKv lijMuZX0XHpX6NDdlnIXzCoCbS+5r4mFbOF5iPogNSAy3abot/RNUwX8pYlTY5PjWS7c vdk+P+H6H2tTCLeBrUR+Y3bLSaudhzl8bUzqWddDnWDbNHIN6xrqJNs0ZfDq3dwAdcBN 0euA== X-Gm-Message-State: AODbwcB/vciTksjWpOV4kEymjzhk1YPNwXnxuRmVgqC3KPoUXTTLJXwz rm/ueEw6NihD1SMWvlo= X-Received: by 10.98.156.133 with SMTP id u5mr30150738pfk.76.1496252333927; Wed, 31 May 2017 10:38:53 -0700 (PDT) Received: from ?IPv6:2607:fb90:834d:ae5f:d516:4603:4950:1427? ([2607:fb90:834d:ae5f:d516:4603:4950:1427]) by smtp.gmail.com with ESMTPSA id p13sm34002465pfl.52.2017.05.31.10.38.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 May 2017 10:38:53 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r319125 - head/usr.bin/mkimg From: Ngie Cooper X-Mailer: iPhone Mail (14F89) In-Reply-To: <20170531114829.28359de76187bdd184746b5a@bidouilliste.com> Date: Wed, 31 May 2017 10:38:52 -0700 Cc: Emmanuel Vadot , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <950A1301-50D2-490B-9598-5248AF246985@gmail.com> References: <201705291251.v4TCp24h090283@repo.freebsd.org> <20170531114829.28359de76187bdd184746b5a@bidouilliste.com> To: Emmanuel Vadot X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 17:38:54 -0000 > On May 31, 2017, at 02:48, Emmanuel Vadot wrote: >=20 > On Wed, 31 May 2017 00:20:45 -0700 > "Ngie Cooper (yaneurabeya)" wrote: >=20 >>=20 >>> On May 29, 2017, at 05:51, Emmanuel Vadot wrote: >>>=20 >>> Author: manu >>> Date: Mon May 29 12:51:02 2017 >>> New Revision: 319125 >>> URL: https://svnweb.freebsd.org/changeset/base/319125 >>>=20 >>> Log: >>> mkimg: Correct an off by one error in the PMBR size >>>=20 >>> The PMBR last sector should be number of sector - 1 (As stated in UEFI S= pec >>> 2.6 page 118 table 17). >>> This fixes warning printed by linux tools like parted or fdisk. >>=20 >> This commit broke all of the mkimg gpt tests. For example: https://ci.fre= ebsd.org/job/FreeBSD-head-amd64-test/3280/testReport/junit/usr.bin.mkimg/mki= mg_test/gpt_1x1_4096_qcow/ . >> -Ngie >=20 > Sorry about that and thanks for the fix. No worries -- it turns out I broke something by accident as well, and I f= ixed both items at the same time. Take it easy :), -Ngie=