From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Jan 26 01:33:57 2006
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A1B3316A425;
	Thu, 26 Jan 2006 01:33:57 +0000 (GMT)
	(envelope-from jylefort@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 079C843D55;
	Thu, 26 Jan 2006 01:33:57 +0000 (GMT)
	(envelope-from jylefort@FreeBSD.org)
Received: from freefall.freebsd.org (jylefort@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k0Q1Xu8H056177;
	Thu, 26 Jan 2006 01:33:56 GMT
	(envelope-from jylefort@freefall.freebsd.org)
Received: (from jylefort@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k0Q1XuqM056173;
	Thu, 26 Jan 2006 01:33:56 GMT (envelope-from jylefort)
Date: Thu, 26 Jan 2006 01:33:56 GMT
From: Jean-Yves Lefort <jylefort@FreeBSD.org>
Message-Id: <200601260133.k0Q1XuqM056173@freefall.freebsd.org>
To: Lars.Engels@0x20.net, jylefort@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc: 
Subject: Re: ports/91981: [Maintainer Update] german/tvbrowser: use new
	start script
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jan 2006 01:33:57 -0000

Synopsis: [Maintainer Update] german/tvbrowser: use new start script

State-Changed-From-To: open->feedback
State-Changed-By: jylefort
State-Changed-When: Thu Jan 26 01:25:10 UTC 2006
State-Changed-Why: 
I see the following problems with your script:

  - it prints useless spam to standard output
  - it uselessly checks for java
  - it remains loaded while java is executing
  - it uselessly depends on bash

I propose the following version instead (needs testing):

#!/bin/sh
exec %%LOCALBASE%%/bin/java -jar %%DATADIR%%/tvbrowser.jar "$@"
You do not need such a bloated bash script

http://www.freebsd.org/cgi/query-pr.cgi?pr=91981