Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Jan 2006 01:33:56 GMT
From:      Jean-Yves Lefort <jylefort@FreeBSD.org>
To:        Lars.Engels@0x20.net, jylefort@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Subject:   Re: ports/91981: [Maintainer Update] german/tvbrowser: use new start script
Message-ID:  <200601260133.k0Q1XuqM056173@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
Synopsis: [Maintainer Update] german/tvbrowser: use new start script

State-Changed-From-To: open->feedback
State-Changed-By: jylefort
State-Changed-When: Thu Jan 26 01:25:10 UTC 2006
State-Changed-Why: 
I see the following problems with your script:

  - it prints useless spam to standard output
  - it uselessly checks for java
  - it remains loaded while java is executing
  - it uselessly depends on bash

I propose the following version instead (needs testing):

#!/bin/sh
exec %%LOCALBASE%%/bin/java -jar %%DATADIR%%/tvbrowser.jar "$@"
You do not need such a bloated bash script

http://www.freebsd.org/cgi/query-pr.cgi?pr=91981



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601260133.k0Q1XuqM056173>