Date: Wed, 17 Jun 2009 11:55:46 +0300 From: Peter Pentchev <roam@ringlet.net> To: Andrea 'simplex' Zulato <simplex@twopenguins.it> Cc: =?windows-1251?B?yOv8/yDA7eTw5eXi?= <admin@aivus.name>, freebsd-ports@freebsd.org, Gerrit Beine <gerrit.beine@gmx.de> Subject: Re: Unrealircd problems with last patch Message-ID: <20090617085546.GB976@straylight.m.ringlet.net> In-Reply-To: <20090617085202.GA976@straylight.m.ringlet.net> References: <4A388C26.3050900@twopenguins.it> <20090617085202.GA976@straylight.m.ringlet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--FsscpQKzF/jJk6ya
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Jun 17, 2009 at 11:52:02AM +0300, Peter Pentchev wrote:
> On Wed, Jun 17, 2009 at 08:24:38AM +0200, Andrea 'simplex' Zulato wrote:
> > Hi, i've upgraded c-ares and Unreal from ports but Unreal won't work.
> > It start without a problem but when someone try to connect to the server
> > it crash with a core dump error:
> > Jun 16 09:03:33 hazard kernel: pid 57652 (ircd), uid 0: exited on signal
> > 11 (core dumped)
> > I've tried to recompile unreal and c-ares whitout any result ("make
> > install" finish without problems on both ports).
> > If there's something that i could try, please tell me...
> > I'm on a FreeBSD 7.2-RELEASE-p1 #0.
>=20
> Hi,
>=20
> I've CC'd Gerrit Beine (the actual maintainer of the irc/unreal port :)
> and Ilya Andreev, who reported the same problem to me yesterday.
>=20
> Some time ago, I sent my proposed c-ares update for testing to all
> the maintainers of ports that depend on c-ares directly. My patches
> made the ports compile, but I didn't have the proper setup to actually
> test them working, since I'm not quite familiar with the programs
> themselves. Thus, I asked the maintainers for help with testing, and
> after nobody replied for a week or so, I went ahead and commited the upda=
te.
>=20
> Now Ilya Andreev and you have both hit a problem with UnrealIRCd,
> and Ilya seems to have found a solution. Could you try putting
> the attached patch-res.c into the irc/unreal/files/ directory and
> rebuilding UnrealIRCd? If this patch helps, I could commit it if
> Gerrit Beine does not mind.
Hmm, that's funny. I keep forgetting that sometimes mailing lists
may strip attachments :) Here's the patch (sorry if you're receiving
it twice)
G'luck,
Peter
diff -u -r1.1.1.1.6.1.2.71.2.26 -r1.1.1.1.6.1.2.71.2.27
--- src/res.c 2009/02/01 16:43:33 1.1.1.1.6.1.2.71.2.26
+++ src/res.c 2009/05/13 10:28:06 1.1.1.1.6.1.2.71.2.27
@@ -722,21 +722,34 @@
} else
if (*param =3D=3D 'i') /* INFORMATION */
{
- struct ares_config_info inf;
+ struct ares_options inf;
int i;
+ int optmask;
=09
- ares_get_config(&inf, resolver_channel);
+ ares_save_options(resolver_channel, &inf, &optmask);
=20
sendtxtnumeric(sptr, "****** DNS Configuration Information ******");
sendtxtnumeric(sptr, " c-ares version: %s",ares_version(NULL));
- sendtxtnumeric(sptr, " timeout: %d", inf.timeout);
- sendtxtnumeric(sptr, " tries: %d", inf.tries);
- sendtxtnumeric(sptr, " # of servers: %d", inf.numservers);
- for (i =3D 0; i < inf.numservers; i++)
- sendtxtnumeric(sptr, " server #%d: %s", i+1, inf.servers[i] ? inf.=
servers[i] : "[???]");
- =09
- /* TODO: free or get memleak ! */
+
+ if(optmask & ARES_OPT_TIMEOUTMS)
+ sendtxtnumeric(sptr, " timeout: %d", inf.timeout);
+ if(optmask & ARES_OPT_TRIES)
+ sendtxtnumeric(sptr, " tries: %d", inf.tries);
+ if(optmask & ARES_OPT_SERVERS)
+ {
+ sendtxtnumeric(sptr, " # of servers: %d", inf.nservers);
+ for (i =3D 0; i < inf.nservers; i++)
+ sendtxtnumeric(sptr, " server #%d: %s", i+1, inet_ntoa(inf.server=
s[i]));=09
+ }
+ if(optmask & ARES_OPT_DOMAINS)
+ {
+ sendtxtnumeric(sptr, " # of search domains: %d", inf.ndomains);
+ for (i =3D 0; i < inf.ndomains; i++)
+ sendtxtnumeric(sptr, " domain #%d: %s", i+1, inf.domains[i]);
+ }
sendtxtnumeric(sptr, "****** End of DNS Configuration Info ******");
+ =09
+ ares_destroy_options(&inf);
} else /* STATISTICS */
{
sendtxtnumeric(sptr, "DNS CACHE Stats:");
--=20
Peter Pentchev roam@ringlet.net roam@space.bg roam@FreeBSD.org
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
I am the thought you are now thinking.
--FsscpQKzF/jJk6ya
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)
iEYEARECAAYFAko4r5IACgkQ7Ri2jRYZRVO70ACbBTG0G+Esm4b6gT6o9Rttdk9h
gI4AoMcAXsLKljqLGOYWb0UFdZW/TvTT
=FcGH
-----END PGP SIGNATURE-----
--FsscpQKzF/jJk6ya--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090617085546.GB976>