Date: Sun, 24 Dec 2023 16:38:58 -0500 From: "Mikhail T." <mi+t@virtual-estates.net> To: Gleb Popov <arrowd@freebsd.org>, Mikhail Teterin <mi@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 76772c2b0759 - main - www/websh: Unbreak, undeprecate, unexpire. Add LICENSE. Message-ID: <22e32001-b097-47d8-8866-083727424152@virtual-estates.net> In-Reply-To: <CALH631=2ERzQpyFMC8MB9GtsS%2BTrDMMz%2B0DXGdhh0PAKF6jCsA@mail.gmail.com> References: <202312242103.3BOL3Ea7060148@gitrepo.freebsd.org> <CALH631=2ERzQpyFMC8MB9GtsS%2BTrDMMz%2B0DXGdhh0PAKF6jCsA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------11rPJi26WIvqEZ0XUFj8rLC9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit 24.12.23 16:07, Gleb Popov: > Porter Handbook suggests defining TEST_TARGET: TEST_TARGET identifies the make-target in the upstream's Makefile, does not it? Not in the port's Makefile, which, as you can see upon closer examination, is different... The problem with the upstream's test-target is that it always succeeds -- even if a test fails. So I have a little awk-script, which parses the results. > https://docs.freebsd.org/en/books/porters-handbook/book/#make-test I don't see, where that text prohibits -- or even discourages -- what I am doing. Do you? -mi --------------11rPJi26WIvqEZ0XUFj8rLC9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit <!DOCTYPE html> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">24.12.23 16:07, Gleb Popov:<br> </div> <blockquote type="cite" cite="mid:CALH631=2ERzQpyFMC8MB9GtsS+TrDMMz+0DXGdhh0PAKF6jCsA@mail.gmail.com"> <pre>Porter Handbook suggests defining TEST_TARGET: </pre> </blockquote> <p>TEST_TARGET identifies the make-target in the upstream's Makefile, does not it? Not in the port's Makefile, which, as you can see upon closer examination, is different...</p> <p>The problem with the upstream's test-target is that it always succeeds -- even if a test fails. So I have a little awk-script, which parses the results.<br> </p> <p> <blockquote type="cite"> <pre class="moz-quote-pre" wrap=""><a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/books/porters-handbook/book/#make-test">https://docs.freebsd.org/en/books/porters-handbook/book/#make-test</a> </pre> </blockquote> I don't see, where that text prohibits -- or even discourages -- what I am doing. Do you?<br> </p> <blockquote>-mi<br> </blockquote> </body> </html> --------------11rPJi26WIvqEZ0XUFj8rLC9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?22e32001-b097-47d8-8866-083727424152>