From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Apr 23 06:20:13 2005 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B62D16A4D1 for ; Sat, 23 Apr 2005 06:20:13 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1570F43D2F for ; Sat, 23 Apr 2005 06:20:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3N6KCpj087608 for ; Sat, 23 Apr 2005 06:20:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3N6KCFF087604; Sat, 23 Apr 2005 06:20:12 GMT (envelope-from gnats) Resent-Date: Sat, 23 Apr 2005 06:20:12 GMT Resent-Message-Id: <200504230620.j3N6KCFF087604@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Matthew Seaman Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 73A5F16A4CE for ; Sat, 23 Apr 2005 06:18:11 +0000 (GMT) Received: from male.aldigital.co.uk (male.thebunker.net [213.129.64.13]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0989A43D55 for ; Sat, 23 Apr 2005 06:18:11 +0000 (GMT) (envelope-from matthew@thebunker.net) Received: from gravitas.thebunker.net (gateway.ash.thebunker.net [213.129.64.4]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (No client certificate requested) by male.aldigital.co.uk (Postfix) with ESMTP id 1DD9A9767B for ; Sat, 23 Apr 2005 07:18:10 +0100 (BST) Received: from gravitas.thebunker.net (localhost [127.0.0.1]) j3N6I9SI035989 for ; Sat, 23 Apr 2005 07:18:09 +0100 (BST) (envelope-from matthew@gravitas.thebunker.net) Received: (from matthew@localhost) by gravitas.thebunker.net (8.13.3/8.13.3/Submit) id j3N6I9S0035988; Sat, 23 Apr 2005 07:18:09 +0100 (BST) (envelope-from matthew) Message-Id: <200504230618.j3N6I9S0035988@gravitas.thebunker.net> Date: Sat, 23 Apr 2005 07:18:09 +0100 (BST) From: Matthew Seaman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/80271: [maintainer] Use $JAVAJARDIR and $JAVALIBDIR correctly X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Matthew Seaman List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Apr 2005 06:20:13 -0000 >Number: 80271 >Category: ports >Synopsis: [maintainer] Use $JAVAJARDIR and $JAVALIBDIR correctly >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sat Apr 23 06:20:12 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Matthew Seaman >Release: FreeBSD 5.4-STABLE i386 >Organization: Infracaninophile >Environment: System: FreeBSD gravitas.thebunker.net 5.4-STABLE FreeBSD 5.4-STABLE #11: Sat Apr 9 12:49:23 BST 2005 root@gravitas.thebunker.net:/usr/obj/usr/src/sys/GRAVITAS i386 >Description: The Porter's Handbook says: Table 6-7. Constants defined for ports that use Java Constant Value JAVASHAREDIR The base directory for everything related to Java. Default: ${PREFIX}/share/java. JAVAJARDIR The directory where JAR files should be installed. Default: ${JAVASHAREDIR}/classes. JAVALIBDIR The directory where JAR files installed by other ports are located. Default: ${LOCALBASE}/share/java/classes. and I now realise that in various places where I've been using JAVAJARDIR, I should really have been using JAVALIBDIR (Second PR on the same port tonight. Sorry about that) >How-To-Repeat: >Fix: --- mysql-connector-java.diff begins here --- diff -Nur /usr/ports/databases/mysql-connector-java/Makefile mysql-connector-java/Makefile --- /usr/ports/databases/mysql-connector-java/Makefile Sat Apr 23 06:37:07 2005 +++ mysql-connector-java/Makefile Sat Apr 23 06:30:39 2005 @@ -2,7 +2,7 @@ # Date created: 8 October 2003 # Whom: Matthew Seaman # -# $FreeBSD: ports/databases/mysql-connector-java/Makefile,v 1.32 2005/04/23 03:15:00 hq Exp $ +# $FreeBSD: ports/databases/mysql-connector-java/Makefile,v 1.31 2005/02/22 21:17:44 hq Exp $ # PORTNAME= mysql-connector-java @@ -25,7 +25,7 @@ USE_ANT= yes JAVA_VERSION= 1.4+ ALL_TARGET= clean compile-driver -MAKE_ARGS= -Djavajardir=${JAVAJARDIR} +MAKE_ARGS= -Djavalibdir=${JAVALIBDIR} BUILDDIR= ${WRKDIR}/build-mysql-jdbc/${DISTNAME} .else diff -Nur /usr/ports/databases/mysql-connector-java/files/patch-build.xml mysql-connector-java/files/patch-build.xml --- /usr/ports/databases/mysql-connector-java/files/patch-build.xml Wed Feb 23 09:20:10 2005 +++ mysql-connector-java/files/patch-build.xml Sat Apr 23 06:31:03 2005 @@ -4,7 +4,7 @@ -+ ++ + + + --- mysql-connector-java.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: