Date: Mon, 1 Jun 2020 11:44:32 +0000 From: "ae (Andrey V. Elsukov)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-net@freebsd.org Subject: [Differential] D24989: netinet: Generate a random RSS key on boot. Message-ID: <e565cbd1880450f545d098d66dce3d99@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-yukac7sf5rncf2mc6vjo-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-yukac7sf5rncf2mc6vjo-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
ae added a comment. In D24989#552576 <https://reviews.freebsd.org/D24989#552576>, @avg wrote: > I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies). > So, maybe just being random is not good enough? > I think that hypothetical `rss_isbadkey` was mentioned for a reason? I also have such feeling. For example, you have some server that handles some serious workload, but after reboot due to the new key it will not be able to handle the same workload. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D24989/new/ REVISION DETAIL https://reviews.freebsd.org/D24989 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org, #csprng, markm Cc: avg, markm, cem, #csprng, kevans, debdrup, rwatson, imp, ae, melifaro, #contributor_reviews_base, freebsd-net-list, mmacy, kpraveen.lkml_gmail.com, marcnarc_gmail.com, simonvella_gmail.com, novice_techie.com, tommi.pernila_iki.fi, krzysztof.galazka_intel.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e565cbd1880450f545d098d66dce3d99>