From owner-freebsd-pf@FreeBSD.ORG Wed Sep 29 00:56:15 2004 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7807C16A4CE; Wed, 29 Sep 2004 00:56:15 +0000 (GMT) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id D8ABA43D39; Wed, 29 Sep 2004 00:56:14 +0000 (GMT) (envelope-from max@love2party.net) Received: from [212.227.126.205] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1CCSlN-0002vk-00; Wed, 29 Sep 2004 02:56:09 +0200 Received: from [217.83.9.48] (helo=donor.laier.local) by mrelayng.kundenserver.de with asmtp (TLSv1:RC4-MD5:128) (Exim 3.35 #1) id 1CCSlM-0007Nd-00; Wed, 29 Sep 2004 02:56:08 +0200 From: Max Laier To: Wiktor Niesiobedzki Date: Wed, 29 Sep 2004 02:55:09 +0200 User-Agent: KMail/1.7 References: <20040924223754.GA86799@freefall.freebsd.org> <20040928180100.GE1760@mail.evip.pl> In-Reply-To: <20040928180100.GE1760@mail.evip.pl> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7562195.AI5OhU5A9J"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200409290255.22309.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:61c499deaeeba3ba5be80f48ecc83056 cc: ipfw@freebsd.org cc: hackers@freebsd.org cc: "Christian S.J. Peron" cc: freebsd-pf@freebsd.org Subject: Re: fixes for ipfw and pf lock ordering issues X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2004 00:56:15 -0000 --nextPart7562195.AI5OhU5A9J Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 28 September 2004 20:01, Wiktor Niesiobedzki wrote: > On Fri, Sep 24, 2004 at 10:37:54PM +0000, Christian S.J. Peron wrote: > > Good day folks, we need some beta testers > > Hi, as an author of LOR reports I feel obliged to test this patch. I was > running it for a 2 days and intended to report, that for me everything > works ok, when an panic occured. Regretably, I do not have actual panic > message, but the trace looks as follows: > pf_socket_lookup(cbb24958,cbb2495c,2,cbb24a0c,c15275a0) at > pf_socket_lookup+0x22 > pf_test_tcp(cbb249c0,cbb249bc,2,c14d6200,c139e500) at pf_test_tcp+0x648 > pf_test(2,c14b8014,cbb24aa8,c15275a0,c15661c0) at pf_test+0x53d > pf_check_out(0,cbb24aa8,c14b8014,2,c15275a0) at pf_check_out+0x6d > pfil_run_hooks(c066da00,cbb24b1c,c14b8014,2,c15275a0) at > pfil_run_hooks+0xeb ip_output(c139e500,0,cbb24ae8,0,0) at ip_output+0x630 > tcp_twrespond(c18709a0,10,c0607304,69c,1) at tcp_twrespond+0x1ed > tcp_twstart(c186b380,0,c0606ba2,96f,0) at tcp_twstart+0x1d3 > tcp_input(c139d800,14,c14b8014,1,0) at tcp_input+0x2c39 > ip_input(c139d800,0,c06053ae,e7,c066d098) at ip_input+0x5b0 > netisr_processqueue(c066d098,c0642940,1,c05fb4da,c10d62c0) at > netisr_processqueu > e+0x8e > swi_net(0,0,c05f9b18,269,0) at swi_net+0xe9 > ithread_loop(c10de480,cbb24d48,c05f990f,31f,1000000) at ithread_loop+0x172 > fork_exit(c04a6520,c10de480,cbb24d48) at fork_exit+0xc6 > fork_trampoline() at fork_trampoline+0x8 > --- trap 0x1, eip =3D 0, esp =3D 0xcbb24d7c, ebp =3D 0 --- > db> > > db> show locks > exclusive sleep mutex inp (tcpinp) r =3D 0 (0xc1527630) locked @ > /usr/src/sys/neti > net/tcp_input.c:737 > exclusive sleep mutex tcp r =3D 0 (0xc066de6c) locked @ > /usr/src/sys/netinet/tcp_i > nput.c:611 > db> > > (gdb) l *pf_socket_lookup+0x22 > 0xc043a2d2 is in pf_socket_lookup (/usr/src/sys/contrib/pf/net/pf.c:2414). > 2409 #endif > 2410 struct inpcb *inp; > 2411 > 2412 #ifdef __FreeBSD__ > 2413 if (inp_arg !=3D NULL) { > 2414 *uid =3D inp_arg->inp_socket->so_cred->cr_uid; > 2415 *gid =3D inp_arg->inp_socket->so_cred->cr_groups[= 0]; > 2416 return (1); > 2417 } > 2418 #endif This should read: > *uid =3D UID_MAX; > *gid =3D GID_MAX; > #ifdef __FreeBSD__ > if (inp_arg !=3D NULL) { > if (inp_arg->inp_socket) { > *uid =3D inp_arg->inp_socket->so_cred->cr_uid; > *gid =3D inp_arg->inp_socket->so_cred->cr_groups[= 0]; > return (1); > } else > return (0); > } > #endif now. Thanks for testing, I will post an updated patch the other day. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart7562195.AI5OhU5A9J Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQBBWgf6XyyEoT62BG0RAgx5AJ9/RQ971H3oQ18mYgo19wD/XBXiIACeMqsD JSk9Pz90fJXmrHlvsBlyNgE= =Fs+l -----END PGP SIGNATURE----- --nextPart7562195.AI5OhU5A9J--