From owner-cvs-all Sat Oct 12 15:21:42 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 17F3637B401; Sat, 12 Oct 2002 15:21:39 -0700 (PDT) Received: from obsecurity.dyndns.org (adsl-64-165-226-88.dsl.lsan03.pacbell.net [64.165.226.88]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6BF3C43EA3; Sat, 12 Oct 2002 15:21:38 -0700 (PDT) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id DA53B66B5E; Sat, 12 Oct 2002 15:21:37 -0700 (PDT) Date: Sat, 12 Oct 2002 15:21:37 -0700 From: Kris Kennaway To: Robert Watson Cc: Kris Kennaway , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libdisk disk.c Message-ID: <20021012222137.GA95508@xor.obsecurity.org> References: <20021012220432.GA95038@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 12, 2002 at 06:11:51PM -0400, Robert Watson wrote: >=20 > On Sat, 12 Oct 2002, Kris Kennaway wrote: >=20 > > On Sat, Oct 12, 2002 at 03:01:57PM -0700, Kris Kennaway wrote: > > > kris 2002/10/12 15:01:57 PDT > > >=20 > > > Modified files: > > > lib/libdisk disk.c=20 > > > Log: > > > Zero memory after malloc. This stops sysinstall from dumping core > > > during disk probing with malloc debugging enabled. > >=20 > > I have no idea how this went for so long without being noticed.=20 > > sysinstall wouldn't even start with the default malloc settings.=20 >=20 > That is odd -- I use sysinstall with relative frequency for disk labeling > and prep. I've also had a number of coworkers install -CURRENT using > recent snapshots and they haven't run into it... Here's the backtrace I was getting: #0 strsep (stringp=3D0xbfbfdcc8, delim=3D0x8093e7a " ") at /usr/src/lib/libc/string/strsep.c:67 #1 0x0806b22e in Disk_Names () at /usr/src/lib/libdisk/disk.c:522 #2 0x0804f2f2 in deviceGetAll () at /usr/src/usr.sbin/sysinstall/devices.c= :439 #3 0x0805cbab in main (argc=3D1, argv=3D0xbfbff820) at /usr/src/usr.sbin/sysinstall/main.c:128 #4 0x0804b2dc in _start (ap=3D0xbfbff900 "sysinstall") at /usr/src/lib/csu/i386-elf/crt1.c:126 (gdb) frame 1 #1 0x0806b22e in Disk_Names () at /usr/src/lib/libdisk/disk.c:522 522 for (dp =3D disks; ((*dp =3D strsep(&disklist, " ")) != =3D NULL) && (gdb) print disklist $1 =3D 0x80d6130 "ad0", '' ... (the character between the '' is ascii 0xd0, the character malloc debugging uses with the 'J' flag). I don't know why other people hadnt seen this. Kris --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9qKBxWry0BWjoQKURArVvAKDWfv2LJOFOHooC6mY0B1XLz2dulACdHuQL O5g3UGR1NVqMnTMXRJVEeGg= =W1jc -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message