From nobody Sat Sep 23 01:54:35 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RssdS228Gz4tpMw; Sat, 23 Sep 2023 01:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RssdS1VYYz3MlM; Sat, 23 Sep 2023 01:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695434076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tITwXaQqLYH3Sz9ReYwgUfK/WRkW59xMrKF3mNQfM4Y=; b=iwx2fiWVIv2tnXRQ/Mql3im42WT+UiYmbUQmCL/uOKOu8nmB2wbvJmsWp71WUl+/Kzpyd+ +S/1y/bgBjKnDbkSHq7kcjeyVkuXHxIQokxIV+6/7xFH7ApFCAbqHNYNVKPevSDeomi9my Nc+xCM/hPCpFk4Z3ScHVNw94rARTGohvtnn+2wgFB8PIkTuHaQ40p/VQJeSAk3WLcYmgIq UYgCzE4elO0wJnrhTZCZbdzxZsfZvQOqJvPG2rf6n/fjoQybC9q+tMgRtHIU77FVWEKdGZ 0RWnMWXRQhnZ+o4CfJ/hagEhHXXc9T+uGpbjM0eTtje0+a9dodWSELEmdM+9kQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695434076; a=rsa-sha256; cv=none; b=jWSDx28AXaZKS/2aCxkYIoIxRF/0c/U5Xjt9SrO13WHuHEOFW5F6a5AnTPq8iocHI47INh 4ix1c4eTE5fx2Zjt5tcjrfEjqwDUIAuatL9/YDn4E49+kT2+I5VgzYogCbZhMieop0gJnI ZjnO4AVUGpH1Uwl0d7W9er2NL0jNTSxwMjkN6pB83WLFhqd1RzqJS/TvbDdwffOMi02Yyf 12TH171KpWmG96f6Q2oprBvUFPu/mI/Xziu9/YAD2Vof2BIGzinLzevxfSBjt3NQhUdocC za2CUhKdfRqaXght/DZ/qYmdca/5d0yr0KaNlspxv5OZ387pjFzKtTvlRcVTjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695434076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tITwXaQqLYH3Sz9ReYwgUfK/WRkW59xMrKF3mNQfM4Y=; b=RNAHt0pgDP/mdb/WyWJmYi93JosHwwIJDFpC7MVhYCznNPdtuAhKnXefz2IlgpRe+zF2L9 o5b1fUtLZ4iIZwH15aZY+pI8owFCtyuPMVBNCr9GnASRMmmkZYzCeM00TLWDPFkRtHUBm3 9NRM8C8kmZ5mP6iMDww/stpxDYk3sd1IKgekdmWRmSd5EbLr7LWAdQnus6rpH2aIuz7B2u w8crGl/l0cleBYmSejuaYcPalULbv8DqyQqnb4IsEEhta/KYKm6Dcp4WnUjvq2H5rwdeea 1pM7CUMurKKRZFrkvVN7TJmlkDCDPLYbn1A2IIF8c+YWtsd7E/Fu3aMnNux69A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RssdS0WQTzlTw; Sat, 23 Sep 2023 01:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38N1sZpm057174; Sat, 23 Sep 2023 01:54:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38N1sZuZ057171; Sat, 23 Sep 2023 01:54:35 GMT (envelope-from git) Date: Sat, 23 Sep 2023 01:54:35 GMT Message-Id: <202309230154.38N1sZuZ057171@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Doug Moore Subject: git: d9b8e5a74805 - releng/14.0 - powerpc pmap: initialize kernel pmap radix trie List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: d9b8e5a748053ed9c641b5ac3832463b6f3731ac Auto-Submitted: auto-generated The branch releng/14.0 has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=d9b8e5a748053ed9c641b5ac3832463b6f3731ac commit d9b8e5a748053ed9c641b5ac3832463b6f3731ac Author: Doug Moore AuthorDate: 2023-09-13 18:17:57 +0000 Commit: Doug Moore CommitDate: 2023-09-23 01:49:16 +0000 powerpc pmap: initialize kernel pmap radix trie Commit 2d2bcba7ba70141388729ed49674b36fd01146c5 changed radix trie implementation and made it necessary that radix tries be initialized with vm_radix_init. @dbaio reports that in some configurations, there is a powerpc boot panic and that this commit introduced the problem. In powerpc/aim/mmu_radix.c, the radix trie in kernel_pmap is initialized by zeroing all its fields. Add a call to vm_radix_init to properly initialize kernel_pmap->pm_radix. Reported by: dbaio Reviewed by: alc, jhibbits Fixes: 2d2bcba7ba drop NULL check from radix trie search Differential Revision: https://reviews.freebsd.org/D41846 (cherry picked from commit 8763b9862f90dc3bdbbc5e3c2664890be7c1f0c4) (cherry picked from commit a4c7a3f7f56a131a74b78ac48f6533feb8ef5aae) Approved by: re (gjb) --- sys/powerpc/aim/mmu_radix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/powerpc/aim/mmu_radix.c b/sys/powerpc/aim/mmu_radix.c index 32d08d2d7026..b904978e042c 100644 --- a/sys/powerpc/aim/mmu_radix.c +++ b/sys/powerpc/aim/mmu_radix.c @@ -1843,6 +1843,7 @@ mmu_radix_setup_pagetables(vm_size_t hwphyssz) bzero(kernel_pmap, sizeof(struct pmap)); PMAP_LOCK_INIT(kernel_pmap); + vm_radix_init(&kernel_pmap->pm_radix); ptpages = allocpages(3); l1phys = moea64_bootstrap_alloc(RADIX_PGD_SIZE, RADIX_PGD_SIZE);