Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 22 Mar 2018 12:50:28 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Gabor Kovesdan <gabor@mypc.hu>
Cc:        Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r465284 - head/x11-fonts/lohit
Message-ID:  <20180322115028.7qi7q65pvricwv7b@ogg.in.absolight.net>
In-Reply-To: <1a18c2f5-9151-6d2c-fd98-3d5aee9a13c4@mypc.hu>
References:  <201803221025.w2MAPK8R092414@repo.freebsd.org> <1a18c2f5-9151-6d2c-fd98-3d5aee9a13c4@mypc.hu>

next in thread | previous in thread | raw e-mail | index | archive | help

--kim3sy3xy35yxhyb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 22, 2018 at 11:46:18AM +0100, Gabor Kovesdan wrote:
>=20
>=20
> On 3/22/2018 11:25 AM, Mathieu Arnold wrote:
> > Author: mat Date: Thu Mar 22 10:25:20 2018 New Revision: 465284=20
> > URL: https://svnweb.freebsd.org/changeset/ports/465284
> >=20
> > Log: Fix previous commit.
> >=20
> > Pointy hat:	gabor Sponsored by:	Absolight
> >=20
> > Modified: head/x11-fonts/lohit/Makefile   (contents, props
> > changed)
> >=20
> > Modified: head/x11-fonts/lohit/Makefile=20
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> >
> >=20
> --- head/x11-fonts/lohit/Makefile	Thu Mar 22 10:14:11 2018	(r465283)
> > +++ head/x11-fonts/lohit/Makefile	Thu Mar 22 10:25:20 2018
> > (r465284) @@ -2,6 +2,7 @@
> >=20
> > PORTNAME=3D	Lohit PORTVERSION=3D	20140220 +PORTREVISION=3D	1 CATEGORIES=
=3D
> > x11-fonts MASTER_SITES=3D	https://releases.pagure.org/lohit/=20
> > DISTNAME=3D	lohit-ttf-${PORTVERSION} @@ -22,7 +23,6 @@ PLIST_FILES=3D
> > ${FONTSDIR}/Lohit-Assamese.ttf \ ${FONTSDIR}/Lohit-Kannada.ttf \=20
> > ${FONTSDIR}/Lohit-Malayalam.ttf \ ${FONTSDIR}/Lohit-Marathi.ttf \=20
> > -#		${FONTSDIR}/Lohit-Nepali.ttf \ ${FONTSDIR}/Lohit-Oriya.ttf \=20
> > ${FONTSDIR}/Lohit-Punjabi.ttf \=20
> > ${FONTSDIR}/Lohit-Tamil-Classical.ttf \
> >=20
>=20
> New version lacks the Nepali font, it wasn't commented out by mistake.
> Please revert.

I will not revert a fix. The new version you committed also lacked Oriya
Punjabi Tamil-Classical Tamil Telugu, whatever those are.

If you write:

FOO=3D a \
#    b \
     c

What makes understand is "FOO=3D a # b c".
So FOO only contains "a", not "a c".

If you want to put back the line I removed to fix your error (which
means that obviously, neither you, nor the submitter ever tested the
patch), you can put it back, but AFTER the list.

Kind regards,

--=20
Mathieu Arnold

--kim3sy3xy35yxhyb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAABCgBmBQJas5iEXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IqgcQAINAJmkQDFLEy2WgDcgznFFp
73z2SW3+MFuNLwQEW4ztNV92gadU1vG46oZEm2EOyKUjfWGhqqZZnxZdVHuke2le
vWoiAGCMAVykyeoMVqicKIvh0pkROjUJLWNdDg7MSiZfs2+YvFBYMddHgJTAe1kg
K9EGn23HmgUlnDjccvJH4DwL9rEAsjIl4mDu0uEedYBXM5qONFQvjzHP5zYIGmza
6l0WWO6/TSed5bVomE64xl6jcYW1TmD4ShS5d2G2XQEzGtU1KoVBthVEi3ZZ8ZiL
qqgsFbkg73uYFjKK7RQHWXv4S+WtmgcFtyBOyW4GLPAb5eaZP+okBfFkgLXUORB3
aWN56SF9ZhjQmrpiY4SjVKg1iiTq473u5KrXM+jdHdGE/GYvpm2ErtvWnYUPSZnj
eS6zQ1ZTxv8gpPqwKHLC11Sv0GQKqCXhX6Hq5v5peZGBAI2QXSjlb2te3vGbMY0x
ox7hOfsNuLAdxlAYtXRdkVcqyjgg3JGRhu+SL/QU1udh7fpBhskwHj+IrqhmVYwo
u2RDPcDtBYFYgrZYpmaPKovgm6Gth3Y5alP9/KF1c7OSrB5RkL17jDgiQZoIn3xc
ckuxVJkouHkgrVSyMO0ooWdHxcWBakppcGYqg8rkvbVBNf3DCN8c13pISFqbPHqs
5iJu15YFlgBd/5g/iMrd
=PHFG
-----END PGP SIGNATURE-----

--kim3sy3xy35yxhyb--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180322115028.7qi7q65pvricwv7b>