From owner-freebsd-net@FreeBSD.ORG Tue May 5 14:52:12 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4896A29C for ; Tue, 5 May 2015 14:52:12 +0000 (UTC) Received: from nm1-vm2.bullet.mail.ne1.yahoo.com (nm1-vm2.bullet.mail.ne1.yahoo.com [98.138.91.17]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1308F1D81 for ; Tue, 5 May 2015 14:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1430837176; bh=mtEzkecF3xNscLPnPNi7ESDrS7fuvaJcfpUpVOrakcI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=obYACstQ/4wGdYY+BU/dI8Tc8o70mUp3gRtsD5RNhfQDlW7dDAB3Ct2fMbsLB4n/asN2uBDBhb/9DUJvTa4KQ00dEBAH9czuY62PMKofu8lPdpoKmlJJJky1XBaP5Lno6W5Zd3hd83BKmRK3vARJsW9AM2TlHZu5IhPGW/RRqhOj2DpB0J65FJ6+ohpXovTWcccdUWcC3aLCBqvo+iESZLQDkZFfRl0MbdVlCQ7d74yvCZgRTieNwBeyVymMHh/fW5U7ero+LebNPUtf6q6Dpx5X1UBo1UieQYwhtvDG9LPXzlDE5aDHb5Un0LYeyCPhkKeGvVzwgymklLHPZdPvLg== Received: from [98.138.101.131] by nm1.bullet.mail.ne1.yahoo.com with NNFMP; 05 May 2015 14:46:16 -0000 Received: from [98.138.89.233] by tm19.bullet.mail.ne1.yahoo.com with NNFMP; 05 May 2015 14:46:16 -0000 Received: from [127.0.0.1] by omp1048.mail.ne1.yahoo.com with NNFMP; 05 May 2015 14:46:16 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 539508.89970.bm@omp1048.mail.ne1.yahoo.com X-YMail-OSG: JmhBPTUVM1muga3r3nda3UkiP02mTsz8CCQkc9z6gS6KHFlTEmcySbI8lUWz4sa 8QJPUkRBbx4D6FjKaeZCOidlKol0aU.xe3M8tfsahYLF1hzHEXCUrfK5WXlq49mbXCO0ABg4VyQn 3dTfz3MoJ4x_jIY3fJWpK1XBHYXwaHSuv28inTbTPID3Fs_4XvpRH6Y1RzcgzCQDhAtCbjkxr.kn cSK1FbFqOr4t_pGkOlb4WhMlIT_HsHc9VrtzEexYJ8nL1xrwQPxdqt9Yjp0S6lxmS2V3BFBl6Dva seD8_nPVipjGfoPTDjWxHzz8ue3xh_PPzORTuHzlaRld9Y08wYYFBBTWHlb55PtK3dS6pKRXaZr2 v_ReRz5gqAiDqxCY9qni91fDc1M7HswMEW5vTsjVT6OKocC9kHFKH05a36CkXG3qhrCdBw6GZ0Ya FkVPP_Pu7.QNCIttyeCSG57ptjj0eXezjpgMtEY9Lsuqv9TDF00iSrXFZo6v_ty_orAwewYeDD0v 8U2jubtLMSwh37Xyqow-- Received: by 98.138.101.183; Tue, 05 May 2015 14:46:16 +0000 Date: Tue, 5 May 2015 14:46:14 +0000 (UTC) From: Barney Cordoba Reply-To: Barney Cordoba To: Jim Thompson , Julian Elischer Cc: Luigi Rizzo , "freebsd-net@freebsd.org" Message-ID: <1441324756.337558.1430837174176.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: <8612DCBA-43BB-498D-97EA-31F3E25F93C8@netgate.com> References: <8612DCBA-43BB-498D-97EA-31F3E25F93C8@netgate.com> Subject: Re: netmap-ipfw on em0 em1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2015 14:52:12 -0000 Are you NOT SHARP ENOUGH to understand that my proposal DOESN'T USE THE NET= WORK STACK? OMFG Julien, perhaps if people weren't so hostile towards commercial companies p= roviding ideas for alternative ways of doing things you'd get more input an= d more help. Why would I want to help these people? BC=20 On Monday, May 4, 2015 11:55 PM, Jim Thompson wrote: =20 =20 > On May 4, 2015, at 10:07 PM, Julian Elischer wrote: >=20 > Jim, and Barney. I hate to sound like a broken record, but we really need= interested people in the network stack. > The people who make the decisions about this are the people who stand up = and say "I have a=C2=A0 few hours I can spend on this". > If you were to do so too, then really, all these issues could be worked o= n. get in there and help rather than standing on the bleachers and offering= advise. >=20 > There is no person working against you here. >=20 > From my counting the current active networking crew is about 10 people. w= ith another 10 doing drivers. > You would have a lot of sway in a group that small. but you have th be in= it first, and the way to do that is to simple start doing stuff.=C2=A0 no-= one was ever sent an invitation. They just turned up. I am (and we are) interested.=C2=A0 I=E2=80=99m a bit short on time, and I = have a project/product (pfSense) to maintain, so I keep other people busy o= n the stack. Examples include: We co-sponsored the AES-GCM work.=C2=A0 Unfortunately, the process stopped = before the IPsec work to leverage this we did made it upstream. As partial remedy, gnn is currently evaluating all the patches from pfSense= for inclusion into the FreeBSD mainline. I was involved in the work to replace the hash function used in pf.=C2=A0 T= his is (only) min 3% gain, more if you carry large state tables. There was a paper presented at AsiaBSDcon, so at least we have a methodolog= y to speak about performance increases.=C2=A0 (Is the methodology in the pa= per perfect?=C2=A0 No.=C2=A0 But at least it=E2=80=99s a stake in the groun= d.) We=E2=80=99re currently working with Intel to bring support for QuickAssist= to FreeBSD.=C2=A0 (Linux has it.)=C2=A0 While that=E2=80=99s not =E2=80=98= networking=E2=80=99 per-se, the larger consumers for the technology are various components in the stack. The other flaws I pointed out are on the list of things for us to work on /= fix.=C2=A0 Someone might get there first, but =E2=80=A6 that=E2=80=99s goo= d.=C2=A0 I only care about getting things fixed. Jim p.s.=C2=A0 yes, I'm working on a commit bit. _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@FreeBSD.ORG Tue May 5 16:15:30 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 483CA46A for ; Tue, 5 May 2015 16:15:30 +0000 (UTC) Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D8EAD1726 for ; Tue, 5 May 2015 16:15:29 +0000 (UTC) Received: by wgyo15 with SMTP id o15so189060657wgy.2 for ; Tue, 05 May 2015 09:15:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type; bh=omVlONadc8QXTRJo2gABPbjoNuXdyS4PezNvVlij5G4=; b=K+3kHus1m25Wg/7kEXSYg8RdGHvGJ130QNEOXLImBv1Hgo0M7sYTy3LEuybBkmSems K/YWBkQdJY112ZU41qdI2C5HGD9DgQYH0FKXiZrE0rxgqag8KeTCLXPIIBhz5MFMiIMb STBmeMeckU8Q52hlA66fsH+AgTVwWjwgZw8hKNVRw53XuNviAPcYIBSIYT3t1Zc1GvSv Lxy3Sqi9RjOpFv00nf0+15x7yOwpiOq3z/qsOnJu9lS0x7rB/v7ljZYxGc3a0PahkqpU f0bPa6yVzio6g1Hg5Yd+nZCe1X/X6VhEDnvZIVVHiTObcr7Qy7bGyQltvi8dYws+pMJm K3/g== X-Gm-Message-State: ALoCoQlbhT3nAfflfQKItQwikanxCQVXB0oa0i9XZOyX33Ux8C1x51IjcCnJpgopZ9j8nv/uGK/B X-Received: by 10.180.94.168 with SMTP id dd8mr5422597wib.76.1430842522586; Tue, 05 May 2015 09:15:22 -0700 (PDT) Received: from FRI2JCHARBON-M1.local ([217.30.88.7]) by mx.google.com with ESMTPSA id n1sm16872166wix.0.2015.05.05.09.15.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2015 09:15:21 -0700 (PDT) Message-ID: <5548EC8F.3010103@freebsd.org> Date: Tue, 05 May 2015 18:15:11 +0200 From: Julien Charbon User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: freebsd-net@freebsd.org Subject: MFC-ing TCP timer race condition fix References: <5548BB20.2020700@freebsd.org> In-Reply-To: <5548BB20.2020700@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mKJSu7EeUI1qCETulT89BN0lwXOD3vGGi" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 May 2015 16:15:30 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mKJSu7EeUI1qCETulT89BN0lwXOD3vGGi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable (Same exact email but with a meaningful topic this time...) Hi list, I was asked if it is possible to MFC r281599 in FreeBSD 10: --- Fix an old and well-documented use-after-free race condition in TCP timers: - Add a reference from tcpcb to its inpcb - Defer tcpcb deletion until TCP timers have finished --- https://svnweb.freebsd.org/base?view=3Drevision&revision=3D281599 First, I thought it was no possible as it touches struct tcp_timer/struct tcpcb_mem. Second, John pointed me that these two structures are used only internally. The only side effect I was able to find is the increase of struct tcpcb_mem size: - stable/10: struct tcpcb_mem size is 1024 bytes - stable/10 + tcp timer change: struct tcpcb_mem size is 1032 bytes - currently in head: struct tcpcb_mem size is 1048 bytes If you have extra concerns on MFC-ing this change please scream. Without nice yelps I plan to "MFC after: 1 month" (around May 16th). Thanks. -- Julien --mKJSu7EeUI1qCETulT89BN0lwXOD3vGGi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVSOyXAAoJEKVlQ5Je6dhx6csIALL2XgySXOU+bPZOlIJRi+2B 1cVMV9615HcSY9vc/s3mqKcuo6uW1GGGk3Q6AKorIqzjmVscanizPA3frcWG4kqt G91kY6TxR1ivmAleCpMhjoVx5Y63qec+EBXIqd9fMIsIO+7iyELpShVBnJQO4RpC 7JvGN3e7MYadisrMQWmHfGKLABxzGKsC+RzHePvV4KAsQbgKk+e5ET+dIVXFTxNN YfgCmpefuCFgsvN5Wot2lw0yDIxrpSllntQw3fg8mKaPiBeiggUXl2h5kqEitrCG Qrin+8N0aod2ytd50D3TlOhk1gYmjL3Gip37cwhpnmjewaxh86XLbPO+o/PbMGM= =xONa -----END PGP SIGNATURE----- --mKJSu7EeUI1qCETulT89BN0lwXOD3vGGi--