From owner-cvs-all@FreeBSD.ORG Fri Feb 25 19:49:52 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8628D16A4CE; Fri, 25 Feb 2005 19:49:52 +0000 (GMT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 39BEB43D41; Fri, 25 Feb 2005 19:49:50 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] (sam@[66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j1PJnlWi028531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 25 Feb 2005 11:49:47 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <421F818A.4020701@errno.com> Date: Fri, 25 Feb 2005 11:50:34 -0800 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208) X-Accept-Language: en-us, en MIME-Version: 1.0 References: <200502251947.j1PJlIXU003272@repoman.freebsd.org> In-Reply-To: <200502251947.j1PJlIXU003272@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/puc puc.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2005 19:49:52 -0000 Sam Leffler wrote: > sam 2005-02-25 19:47:18 UTC > > FreeBSD src repository > > Modified files: > sys/dev/puc puc.c > Log: > fail gracefully rather than using an invalid array index if unable > to allocate a bar; it's unclear whether this can happen in practice If someone can convince themself that we can never fail then feel free to change this code to a KASSERT or similar... Sam